New issue
Advanced search Search tips

Issue 798488 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 798025



Sign in to add a comment

Record metrics on how frequently the renderers are notified of the network quality change

Project Member Reported by tbansal@chromium.org, Jan 2 2018 
Chrome browser process notifies all render processes when there is a change in the network quality. We want this notifications to be less frequent. Currently, the frequency of the notifications is throttled by checking that the new network quality is meaningfully different from the last one. The render processes are notified only if the change in the network quality is large enough (determined using a heuristic).

We should record metrics on how frequently the renderers are notified of the network quality change so that we can tune the heuristic appropriately.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06

commit df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06
Author: Tarun Bansal <tbansal@chromium.org>
Date: Thu Jan 04 02:17:06 2018

Add histogram to record changes in the network quality

Add histogram to record how frequently network quality
is detected as meaningfully changed.

Also, add DCHECKs to verify that the RTTs and throughput
values are as unexpected.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug:  798488 
Change-Id: Ie0bbf1f691a002a9257bff4c089e9dc8d0156b86
Reviewed-on: https://chromium-review.googlesource.com/846285
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526898}
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/content/browser/net/OWNERS
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/content/browser/net/network_quality_observer_impl.cc
[add] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/content/browser/net/network_quality_observer_impl_unittest.cc
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/content/test/BUILD.gn
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/net/nqe/network_quality.cc
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/net/nqe/network_quality.h
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/df224ab1bcee6fdebba820ba3b0d0f4ac6a12f06/tools/metrics/histograms/histograms.xml

Comment 2 by tbansal@chromium.org, Jan 22 2018

Blocking: 798025

Comment 3 by tbansal@chromium.org, Jan 22 2018

Labels: M-65
Status: Fixed (was: Started)
►

Sign in to add a comment