New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798481 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 3
Type: Bug



Sign in to add a comment

Layout tests compositing/gestures/gesture-&*tapHighlight-*.html are flaky

Project Member Reported by tbansal@chromium.org, Jan 2 2018

Issue description

The following layout test is flaky on WebKit Linux Trusty (dbg)

virtual/spv175/compositing/gestures/gesture-tapHighlight-with-box-shadow.html

Link to the run:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/8370

 
Cc: wangxianzhu@chromium.org trchen@chromium.org
Status: Available (was: Untriaged)
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Blocking: 771643

Comment 4 by jwd@chromium.org, Jan 2 2018

Cc: jwd@google.com
 Issue 798527  has been merged into this issue.
The failure seems caused by different visited color of a link. I could not reproduce the bug locally, even by repeating the test 100 times with a debug build.

The base test was once flaky (FAIL FAIL PASS) on 12/28/2017: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/8283.

virtual/spv175/compositing/gestures/gesture-tapHighlight-with-box-shadow.html became very flaky (nearly constantly failing) today.
Blocking: -771643
Summary: Layout Test compositing/gestures/gesture-tapHighlight-with-box-shadow.html is flaky (was: Layout Test virtual/spv175/compositing/gestures/gesture-tapHighlight-with-box-shadow.html is flaky)
The base test was flaky again in a recent build: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=compositing%2Fgestures%2Fgesture-tapHighlight-with-box-shadow.html

So the failure has nothing to do with spv175.

Comment 7 by clamy@chromium.org, Jan 9 2018

This test is still flaky, and only in its spv175 version recently. I'm going to mark it as failing in the test expectations.

Comment 8 by clamy@chromium.org, Jan 9 2018

Sorry I meant another of the gestures tests is flaky with spv175:  virtual/spv175/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html

(See https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/8596).

I'm marking this one as failing.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f736f61c67e5d76e13a9545cfd5bed26e439e229

commit f736f61c67e5d76e13a9545cfd5bed26e439e229
Author: clamy <clamy@chromium.org>
Date: Tue Jan 09 15:28:18 2018

Mark flaky layout test as failing

This CL marks
virtual/spv175/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
as flaky on Linux. It has been failing on the Linux Trusty bot.

TBR=wangxianzhu@chromium.org

Bug:  798481 
Change-Id: I4a9f279ebdae79a1e5e6215630847ed48f59b1b6
Reviewed-on: https://chromium-review.googlesource.com/857002
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527999}
[modify] https://crrev.com/f736f61c67e5d76e13a9545cfd5bed26e439e229/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27c54429bc3f8f539e13892cd2896e3ff78b4b8

commit c27c54429bc3f8f539e13892cd2896e3ff78b4b8
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jan 11 18:00:15 2018

[PE] Deflake compositing/gestures/gesture-*tapHighlight.html

Some tests were flaky because the active state of the tapped link
might continue or have been removed depending on some conditions that
seem not easily controllable. The link in active state or non-active
state were in different colors.

As the purpose of the tests are testing tap highlights and active
state is actually irrelevant, this CL modifies the styles to make
the links use the same color for normal, active or visited states.

Bug:  798481 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I02a104dedd4fd32587d0ce2ba5662cade1a09258
Reviewed-on: https://chromium-review.googlesource.com/849301
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528665}
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-1-overflow-div-composited.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text-2.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-img-and-text.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-inline-block-crash.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-pixel-rotated-link.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-shadow-tree.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-background-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-background.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-body-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-body.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-cancel2.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-longPress.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-multi-line.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-navigate.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-window-scroll-expected.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-simple-window-scroll.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-with-box-shadow.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-with-squashing.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/resources/1-frame-composited.html
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/compositing/gestures/resources/link-highlight-style.css
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/linux/compositing/gestures/gesture-tapHighlight-with-squashing-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/win/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/win/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/win/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png
[modify] https://crrev.com/c27c54429bc3f8f539e13892cd2896e3ff78b4b8/third_party/WebKit/LayoutTests/platform/win/compositing/gestures/gesture-tapHighlight-with-squashing-expected.png

Cc: bokan@chromium.org wjmaclean@chromium.org kenrb@chromium.org creis@chromium.org vollick@chromium.org nasko@chromium.org
 Issue 797964  has been merged into this issue.
Summary: Layout tests compositing/gestures/gesture-&*tapHighlight-*.html are flaky (was: Layout Test compositing/gestures/gesture-tapHighlight-with-box-shadow.html is flaky)
Status: Fixed (was: Assigned)

Sign in to add a comment