New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798436 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

LayoutNG - fix fast/block/float/010.html

Project Member Reported by robho...@gmail.com, Jan 2 2018

Issue description

Don't combine exclusions if descedants contain some, they'll get lost when we split the node and create new descendants.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442328dea93402f53cc0c015d9eac254aa80cb2e

commit 442328dea93402f53cc0c015d9eac254aa80cb2e
Author: Robert Hogan <robhogan@gmail.com>
Date: Wed Jan 03 00:45:18 2018

[LayoutNG] Don't combine exclusions on a node if its desendants have some

If the descendants of an opportunity tree node have exclusions they will
get lost when combining the node's current exclusions, so avoid doing that.

Bug: 798436
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I90cde607c99fcfc808c1dafc531445bc25774cca
Reviewed-on: https://chromium-review.googlesource.com/847595
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526554}
[modify] https://crrev.com/442328dea93402f53cc0c015d9eac254aa80cb2e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/442328dea93402f53cc0c015d9eac254aa80cb2e/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Components: Blink>Layout

Sign in to add a comment