New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798430 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 798426



Sign in to add a comment

Update docs for eventupload

Project Member Reported by katthomas@chromium.org, Jan 2 2018

Issue description

Documentation for eventupload is lacking in a few ways:
The documentation is limited. I think if we move the library to go.chromium.org/luci we’ll get Go-style documentation for free.
Relevant BigQuery limits
Authentication
Error handling and common errors
How to monitor for latency and accuracy

 
Cc: no...@chromium.org
Nodir, is that comment about moving the library to luci correct?

Comment 2 by no...@chromium.org, Jan 2 2018

yes, if the lib is renamed to go.chromium.org/luci/bq, the documentation will be available at https://godoc.org/go.chromium.org/luci/bq.

By BQ limits, do you mean info at https://cloud.google.com/bigquery/quotas
? If so, would referring to that page work?

FWIW IMO auth docs belongs to https://chromium.googlesource.com/infra/infra/+/master/doc/users/event_pipeline.md (is there a go link?), not godoc, because the library is auth-agnostic, i.e. it accepts a pre-configured bq client
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fb0c38e341b89434c44f7dbe049c4bd354e9fae6

commit fb0c38e341b89434c44f7dbe049c4bd354e9fae6
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jan 11 20:00:52 2018

Roll infra/go/src/go.chromium.org/luci/ 94f59dfc7..067307a03 (1 commit)

https://chromium.googlesource.com/infra/luci/luci-go/+log/94f59dfc7055..067307a03d8b

$ git log 94f59dfc7..067307a03 --date=short --no-merges --format='%ad %ae %s'
2018-01-10 katthomas Copy eventupload to luci

Created with:
  roll-dep infra/go/src/go.chromium.org/luci

Bug:798430
Change-Id: I614e740045e89d4eeaf6323a0a6cf51b6cccb62b
Reviewed-on: https://chromium-review.googlesource.com/862198
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[modify] https://crrev.com/fb0c38e341b89434c44f7dbe049c4bd354e9fae6/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/df421420998c5df4dfd76ac6f869ed7aab297458

commit df421420998c5df4dfd76ac6f869ed7aab297458
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jan 11 20:39:03 2018

[eventupload] complete move to luci

R=estaab@chromium.org

Bug:798430
Change-Id: Ib98638e1bcab7bcb9098e6b415205ef95ed2358f
Reviewed-on: https://chromium-review.googlesource.com/862253
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/insertid_test.go
[modify] https://crrev.com/df421420998c5df4dfd76ac6f869ed7aab297458/go/src/infra/appengine/sheriff-o-matic/som/model/model.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/testdata/testmessage.pb.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/eventupload.go
[modify] https://crrev.com/df421420998c5df4dfd76ac6f869ed7aab297458/go/src/infra/appengine/sheriff-o-matic/som/handler/analyze.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/eventupload_test.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/testdata/generate.go
[modify] https://crrev.com/df421420998c5df4dfd76ac6f869ed7aab297458/go/src/infra/appengine/test-results/frontend/event_logging.go
[modify] https://crrev.com/df421420998c5df4dfd76ac6f869ed7aab297458/go/src/infra/tools/kitchen/monitoring.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/testdata/testmessage.proto
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/insertid.go
[delete] https://crrev.com/bc0bab29aa2ae295a554d16e25930b9b19b9999a/go/src/infra/libs/eventupload/eventupload.infra_testing

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/be09ce4c06fb4c6f59ce5c03a4847985fa0f0849

commit be09ce4c06fb4c6f59ce5c03a4847985fa0f0849
Author: Katie Thomas <katthomas@google.com>
Date: Wed Jan 24 19:03:18 2018

[luci/common/bq] add doc.go

Bug:  798430 
Change-Id: I5916bf13b2d4255aa6263df044d4543edacb39b8
Reviewed-on: https://chromium-review.googlesource.com/878503
Commit-Queue: Katie Thomas <katthomas@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[add] https://crrev.com/be09ce4c06fb4c6f59ce5c03a4847985fa0f0849/common/bq/doc.go
[modify] https://crrev.com/be09ce4c06fb4c6f59ce5c03a4847985fa0f0849/common/bq/eventupload.go

EstimatedDays: 2
EstimatedDays: 1
Labels: -Pri-1 Pri-2
Status: Fixed (was: Started)

Sign in to add a comment