New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 791059



Sign in to add a comment

Remove old bqschemaupdater directory

Project Member Reported by katthomas@chromium.org, Jan 2 2018

Issue description

The old bqschemaupdater directory still exists and it’s kind of confusing because now there are two bqschemaudpater directories. We should move those table definitions to more appropriate locations.
 
Labels: -Pri-3 Pri-2
Labels: -Pri-2 Pri-1

Comment 3 by no...@chromium.org, Jan 2 2018

Blockedon: 791059
Cc: no...@chromium.org
We'll also be able to remove bqschema and bqexport.
Nodir, while we're waiting on 791059, can I move the build and step protos somewhere else? Where would you suggest? 
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/06c9e5e1eda720110e12bc25066765767392fa90

commit 06c9e5e1eda720110e12bc25066765767392fa90
Author: Katie Thomas <katthomas@google.com>
Date: Thu Jan 11 18:54:22 2018

[bqschemaupdater] remove old test-results schema

This has been replaced already by the proto in
infra/go/src/infra/appengine/test-results/frontend/model/gen/testresults.proto

Bug:798429
Change-Id: I2cbdd5dcdaef6dbf0778ee358f284f2a0ef898d1
Reviewed-on: https://chromium-review.googlesource.com/861909
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>

[delete] https://crrev.com/a3d7ae5cffa5aae81122d8f66450f114a26c9e3d/go/src/infra/tools/bqschemaupdater/raw_events/test_results.pb.txt

Comment 8 by no...@chromium.org, Jan 11 2018

i think build and step pb txt files can be removed.
build and step protos can be removed too. I won't used them in buildbucket
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1259b0d5b5153778a4fe2a723b0e28d4deb5fb7e

commit 1259b0d5b5153778a4fe2a723b0e28d4deb5fb7e
Author: Katie Thomas <katthomas@google.com>
Date: Fri Jan 12 01:02:23 2018

[bqschemaupdater] remove directory

These aren't compatible with the current version of bqschemaupdater.
I don't suspect we'll want to modify the schema because we're
intending on creating a new events tables for these use cases.

Bug:798429
Change-Id: I481ef7c4915c1f5508c70fd9dbef0cd6b3eead6d
Reviewed-on: https://chromium-review.googlesource.com/861922
Commit-Queue: Katie Thomas <katthomas@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/cq/events.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/raw_events/cq.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/raw_events/buildevent_completed_step_legacy.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/builds/builds.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/builds/steps.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/raw_events/buildevent_completed_build_legacy.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/cq/attempts.pb.txt
[delete] https://crrev.com/b858620ca8807834b12b4d8b6ced4d0bf91936a1/go/src/infra/tools/bqschemaupdater/aggregated/cq_attempts.pb.txt

Status: Fixed (was: Started)

Sign in to add a comment