New issue
Advanced search Search tips

Issue 798412 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 809967
issue 809968

Blocking:
issue 796544



Sign in to add a comment

Convert extensions to use Identity Service client library

Project Member Reported by blundell@chromium.org, Jan 2 2018

Issue description

Most of these are relatively straightforward:

PrivateAPIDrive fetches access tokens for the primary account via google_apis::AuthService
PrivateAPIMisc does the same thing
EnterprisePlatformKeysPrivateAPI: Include looks stale
ChromeFeedbackPrivateDelegate has a public wrapper that returns the email address of the signed-in user
WebstorePrivateAPI returns the signed-in user’s email to the JS side
ExternalComponentLoader’s include looks stale
ExtensionDownloader gets access tokens for the active account via IdentityProvider. This one is not turnkey: Need to check whether this is for PO2TS, DeviceO2TS, or both.

In addition, there is relevant code for app_shell:
//extensions IdentityAPI fetches access tokens via ShellOAuth2TokenService.
//extensions ShellOAuth2TokenService implements OAuth2TokenService.

We'll need to figure out the app_shell question: Is this code relevant going forward? If so, does it need to be converted to use the Identity Service?
 
Blockedon: 809966
Blockedon: 809967
Blockedon: 809968
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b03edd03c0431d97c144591d86069e402bcbc79

commit 2b03edd03c0431d97c144591d86069e402bcbc79
Author: Marc Treib <treib@chromium.org>
Date: Wed Apr 18 17:46:26 2018

Migrate ExtensionInstalledBubbleBrowserTest.InvokeUi_NoAction to IdentityManager

IdentityManager is the new API that replaces the (semi-)deprecated
SigninManager.

Bug:  825190 , 798412
Change-Id: I4bb24b0ebdf0d1d964ce4ad16aa986cc56af2fa4
Reviewed-on: https://chromium-review.googlesource.com/1016760
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551735}
[modify] https://crrev.com/2b03edd03c0431d97c144591d86069e402bcbc79/chrome/browser/ui/extensions/extension_installed_bubble_browsertest.cc

Blockedon: -809966

Sign in to add a comment