Convert settings to use Identity Service client library |
||
Issue descriptionMany of the below usages can be converted in a straightforward way to get the primary account info from and/or observe the IdentityManager. A couple are more complex (called out inline below). PeopleHandler: Observes SigninManager. Checks and sets authenticated account info as part of signin and signout flow and additionally to populate values sent somewhere else (not clear offhand where). We'll need to investigate this one after determining our story for the Identity Service and signin/signout. SearchEnginesHandler checks whether user is signed in as part of determining whether the hotword should always be on and to fill a value that is sent somewhere else (potentially across to the UI?). ClearBrowsingDataHandler gets the authenticated account info to send to JS. SettingsManageProfileHandler includes look stale. AccountsCollectionViewController gets info of all accounts from PO2TS/AccountTrackerService. It also checks the authenticated account info to see if the domain is hosted. ClearBrowsingDataViewController checks whether the user is signed in to control aspects of the UI PrivacyCollectionViewController’s include looks stale SettingsCollectionViewController observes SigninManager to reload data when the signin state changes SyncEncryptionPassphraseCollectionViewController observes O2TS and checks whether user is signed in to check whether to show UI when a batch of refresh token changes is finished. SyncSettingsCollectionViewController gets info of all accounts from PO2TS/AccountTrackerService. It also observes PO2TS to reload data when a batch of refresh token changes is finished. We'll need to have our solution for getting info of all accounts from the Identity Service client lib to convert this one.
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69adf28f5d082c0fc8f23547b985f6829a687b47 commit 69adf28f5d082c0fc8f23547b985f6829a687b47 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jul 09 10:04:22 2018 Remove obsolete includes of SigninManager Bug: 798411 Change-Id: I59b7cb0b3543c097fb27e1b26cbc2966460f6285 Reviewed-on: https://chromium-review.googlesource.com/1127989 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#573259} [modify] https://crrev.com/69adf28f5d082c0fc8f23547b985f6829a687b47/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41d5b9332c4a92add7501f3525711e9b6db5d6fa commit 41d5b9332c4a92add7501f3525711e9b6db5d6fa Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Jul 11 10:52:05 2018 Remove obsolete includes of SigninManager Bug: 798411 Change-Id: I67778d6987e52ecd556aba7c90428a7a6f933e00 Reviewed-on: https://chromium-review.googlesource.com/1129230 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#574123} [modify] https://crrev.com/41d5b9332c4a92add7501f3525711e9b6db5d6fa/chrome/browser/ui/webui/settings/search_engines_handler.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c38f0ec7ae0066ff7752c5ba5ac9dddc7c4f64 commit 08c38f0ec7ae0066ff7752c5ba5ac9dddc7c4f64 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Aug 02 13:59:33 2018 Convert ClearBrowsingDataHandler to use IdentityManager IdentityManager is the recommended API to access the Google account used by the user and SigninManager is deprecated. Convert ClearBrowsingDataHandler to the new API. Bug: 798411 Change-Id: I3dc831307cac65dd42369d7482b9a0b794f02048 Reviewed-on: https://chromium-review.googlesource.com/1126384 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580158} [modify] https://crrev.com/08c38f0ec7ae0066ff7752c5ba5ac9dddc7c4f64/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
,
Dec 11
Closing this bug; the bulk of the work is done here, and the remaining work is being tracked in individual bugs. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 9