New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798355 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8% regression in thread_times.key_silk_cases at 525953:525973

Project Member Reported by alexclarke@chromium.org, Jan 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=798355

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f18ca869002a193d6f49f0b1ce2bf41d189be76da68848c075b45d712d474832


Bot(s) for this bug's original alert(s):

android-one

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_renderer_main_cpu_time_per_frame/http___mobile-news.sandbox.google.com_news_pt0?scroll

Revision             Result                  N
chromium@525952      13.9344 +- 1.99053      21      good
chromium@525973      14.0035 +- 1.49902      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...mobile.news.sandbox.google.com.news.pt0.scroll thread_times.key_silk_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958515360809999904


For feedback, file a bug with component Speed>Bisection
Cc: mlippautz@chromium.org
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author mlippautz@chromium.org ===

Hi mlippautz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Michael Lippautz
  Commit : 07a928267fc62ea5d747a2323dc0244546a70da7
  Date   : Fri Dec 22 14:31:46 2017
  Subject: [oilpan] HeapHashSet add support for incremental marking

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_renderer_main_cpu_time_per_frame/http___mobile-news.sandbox.google.com_news_pt0?scroll
  Change       : 2.36% | 12.861960519 -> 13.1652006649

Revision             Result                   N
chromium@525500      12.862 +- 1.43185        14      good
chromium@525750      12.7244 +- 0.418349      6       good
chromium@525875      58.2408 +- 385.857       9       good
chromium@525937      10.5205 +- 11.5279       6       good
chromium@525968      12.6579 +- 0.650201      9       good
chromium@525984      12.7047 +- 0.335729      6       good
chromium@525986      12.7398 +- 0.589885      9       good
chromium@525987      12.7662 +- 1.15222       14      good
chromium@525988      11.8957 +- 12.64         9       bad       <--
chromium@525992      74.2378 +- 334.762       6       bad
chromium@525999      13.1652 +- 1.09112       14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...mobile.news.sandbox.google.com.news.pt0.scroll thread_times.key_silk_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958416454152610048


For feedback, file a bug with component Speed>Bisection
Cc: -mlippautz@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
The feature is behind a build time flag that is disabled by default. All handlers will yield in empty function calls in this case.

Also, from the results it is not obvious why it should be my CL.
Status: WontFix (was: Untriaged)
That bisect looks incorrect. This came back down, so wontfix-ing.

Sign in to add a comment