[css-multicol] Default column-gap shouldn't be interpolable |
||
Issue descriptionDefault column-gap is interpolable when it shouldn't. For that reason the following test currently fails: http://w3c-test.org/css/css-multicol/multicol-gap-animation-003.html However, "column-gap: normal" is not interpolable, as expected. That's checked in the following test that passes: http://w3c-test.org/css/css-multicol/multicol-gap-animation-002.html Both tests pass on Firefox.
,
Jan 2 2018
Tried this CL: https://chromium-review.googlesource.com/c/chromium/src/+/847476 But it caused regressions in animations/interpolation/webkit-column-gap-interpolation.html, that I don't know how to fix.
,
Jan 2 2018
Rego suggested a solution that works. Attempting to land.
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74f0a79388a89df5bb96dbfd84b298d6f13ae454 commit 74f0a79388a89df5bb96dbfd84b298d6f13ae454 Author: Morten Stenshorne <mstensho@chromium.org> Date: Wed Jan 03 08:51:56 2018 column-gap:normal is not supposed to be interpolable. Bug: 798338 Test: http://w3c-test.org/css/css-multicol/multicol-gap-animation-003.html Change-Id: I352b6a7de8893b27711c178abf7e1ac291429dc3 Reviewed-on: https://chromium-review.googlesource.com/847476 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#526652} [modify] https://crrev.com/74f0a79388a89df5bb96dbfd84b298d6f13ae454/third_party/WebKit/LayoutTests/animations/interpolation/webkit-column-gap-interpolation.html [delete] https://crrev.com/a69bb4d0fbb1ad378f620b416439c9a14fc1d804/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-animation-003-expected.txt [modify] https://crrev.com/74f0a79388a89df5bb96dbfd84b298d6f13ae454/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
,
Jan 3 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mstensho@chromium.org
, Jan 2 2018Status: Assigned (was: Untriaged)