DCHECK(_settingsHasBeenDismissed) failure in -[SettingsCollectionViewController dealloc] |
||||||||||
Issue description
Steps to reproduce:
1. Launch the app
2. Tap on menu
3. Tap on "Settings"
4. Tap on your account
5. Tap on "Google Activity Controls"
6. Tap on "Manager activity"
DCHECK(_settingsHasBeenDismissed) fails.
First -[SettingsNavigationController viewWillDisappear:] is called when it is hidden. This method is called again when tapping on "Manager activity", but -[SettingsNavigationController isBeingDismissed] is NO. Therefore -[SettingsNavigationController settingsWillBeDismissed] is never called.
This doesn't seem to be an issue for release build.
* thread #1, name = 'CrWebMain', queue = 'com.apple.main-thread', stop reason = EXC_BREAKPOINT (code=EXC_I386_BPT, subcode=0x0)
* frame #0: 0x0000000108100414 Chromium`base::debug::BreakDebugger() at debugger_posix.cc:269
frame #1: 0x0000000108163a79 Chromium`logging::LogMessage::~LogMessage(this=0x00007fff59313a20) at logging.cc:844
frame #2: 0x0000000108160195 Chromium`logging::LogMessage::~LogMessage(this=0x00007fff59313a20) at logging.cc:575
frame #3: 0x00000001075c2407 Chromium`::-[SettingsCollectionViewController dealloc](self=0x00007fd3d5068600, _cmd="dealloc") at settings_collection_view_controller.mm:303
frame #4: 0x0000000114321c0d CoreFoundation`cow_cleanup + 125
frame #5: 0x000000011422140d CoreFoundation`-[__NSArrayM dealloc] + 45
frame #6: 0x0000000119833a2e libobjc.A.dylib`objc_object::sidetable_release(bool) + 202
frame #7: 0x00000001121f9bac UIKit`-[UIViewController dealloc] + 1801
frame #8: 0x0000000112229058 UIKit`-[UINavigationController dealloc] + 419
frame #9: 0x00000001121d3e21 UIKit`-[UIPresentationController .cxx_destruct] + 313
frame #10: 0x000000011981d912 libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 127
frame #11: 0x00000001198291a4 libobjc.A.dylib`objc_destructInstance + 124
frame #12: 0x000000010b65b67b Chromium`(anonymous namespace)::ZombieDealloc(self=0x00007fd3d373d130, _cmd="dealloc") at objc_zombie.mm:110
frame #13: 0x00000001121cf41a UIKit`-[UIPresentationController dealloc] + 55
frame #14: 0x0000000112c956be UIKit`-[_UIFullscreenPresentationController dealloc] + 55
frame #15: 0x0000000119833a2e libobjc.A.dylib`objc_object::sidetable_release(bool) + 202
frame #16: 0x00000001121cf0c8 UIKit`__destroy_helper_block_.455 + 24
frame #17: 0x000000011c0ea99d libsystem_blocks.dylib`_Block_release + 111
frame #18: 0x0000000112dc3d23 UIKit`-[_UIViewControllerTransitionContext .cxx_destruct] + 94
frame #19: 0x000000011981d912 libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 127
frame #20: 0x00000001198291a4 libobjc.A.dylib`objc_destructInstance + 124
frame #21: 0x000000010b65b67b Chromium`(anonymous namespace)::ZombieDealloc(self=0x00007fd3db41b260, _cmd="dealloc") at objc_zombie.mm:110
frame #22: 0x0000000112dc250e UIKit`-[_UIViewControllerTransitionContext dealloc] + 55
frame #23: 0x0000000112dc3dc8 UIKit`-[_UIViewControllerOneToOneTransitionContext dealloc] + 78
frame #24: 0x0000000119833a2e libobjc.A.dylib`objc_object::sidetable_release(bool) + 202
frame #25: 0x000000011981d912 libobjc.A.dylib`object_cxxDestructFromClass(objc_object*, objc_class*) + 127
frame #26: 0x00000001198291a4 libobjc.A.dylib`objc_destructInstance + 124
frame #27: 0x000000010b65b67b Chromium`(anonymous namespace)::ZombieDealloc(self=0x000062000004fc90, _cmd="dealloc") at objc_zombie.mm:110
frame #28: 0x0000000119833a2e libobjc.A.dylib`objc_object::sidetable_release(bool) + 202
frame #29: 0x00000001121c7b1f UIKit`-[UITransitionView _didCompleteTransition:] + 1635
frame #30: 0x00000001121ca0c8 UIKit`-[UITransitionView _transitionDidStop:finished:] + 104
frame #31: 0x00000001120eb6c4 UIKit`-[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 343
frame #32: 0x00000001120ebd23 UIKit`-[UIViewAnimationState animationDidStop:finished:] + 293
frame #33: 0x00000001120ebdd7 UIKit`-[UIViewAnimationState animationDidStop:finished:] + 473
frame #34: 0x00000001176d16bd QuartzCore`CA::Layer::run_animation_callbacks(void*) + 323
frame #35: 0x000000011bffd33d libdispatch.dylib`_dispatch_client_callout + 8
frame #36: 0x000000011c0085f9 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 628
frame #37: 0x00000001142b1e39 CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
frame #38: 0x0000000114276462 CoreFoundation`__CFRunLoopRun + 2402
frame #39: 0x0000000114275889 CoreFoundation`CFRunLoopRunSpecific + 409
frame #40: 0x000000011acac9c6 GraphicsServices`GSEventRunModal + 62
frame #41: 0x00000001120555d6 UIKit`UIApplicationMain + 159
frame #42: 0x00000001068ea792 Chromium`(anonymous namespace)::RunUIApplicationMain(argc=1, argv=0x00007fff593163b8) at chrome_exe_main.mm:56
frame #43: 0x00000001068ea263 Chromium`main(argc=1, argv=0x00007fff593163b8) at chrome_exe_main.mm:80
frame #44: 0x000000011c079d81 libdyld.dylib`start + 1
frame #45: 0x000000011c079d81 libdyld.dylib`start + 1
,
Jan 3 2018
,
Jan 3 2018
lpromero@/sczs@: jlebel@ will be OOO for the next 3 weeks. Will any of you be available to take a look at this bug and understand why this DCHECK is fired?
,
Jan 5 2018
Not completely sure if I'll have the bandwidth in the next weeks. peterlaurens@ has been working on Settings lately, ccing him as well!
,
Feb 5 2018
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2018
,
Feb 20 2018
Issue 812855 has been merged into this issue.
,
Mar 12 2018
Marking this as RBS since it is a duplicate of a blocker.
,
Mar 13 2018
I don't think the description of issue 812855 and the description of this bug deserve to be RBS. I did miss crbug.com/812855#c1 which doesn't have to do with the description of both bugs. Should I create a new bug for that comment?
,
Mar 19 2018
Do you have a fix for this issue though?
,
Mar 20 2018
I don't have a fix for this bug description.
,
Mar 23 2018
Please create t a bug for the comment in #9
,
Aug 1
,
Sep 3
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jlebel@chromium.org
, Jan 2 2018