New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798325 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Wi-Fi networks are still seen even after Wi-Fi is turned off in Uber Tray

Project Member Reported by mmanchala@chromium.org, Jan 2 2018

Issue description

Chrome Version: 65.0.3299.0/10271.0.0 dev-channel Peach-Pit,Jerry and Swanky
OS: Chrome

What steps will reproduce the problem?
(1))Sign into User -> At Uber Tray click on 'Sign out'
(2)Now In Sign-out screen  click on 'Add person' -> In Sign-in screen enter Email Id and Click on 'NEXT' -> Now at Uber Tray turn-off WI-FI -> Observe Wi-Fi networks are still seen even after Wi-Fi is turned off
(Please refer video)

Expected: 'Wi-Fi is turned off' message should be seen after disabling Wi-Fi
Actual: Instead  Wi-Fi networks are still seen 

This is Regression Issue as same is working fine in M-62

@tbuckley: Please confirm the Issue
 
Actual_WiFiNetworks.mp4
14.4 MB View Download
Actual_Wi-FiNetworks.jpg
127 KB View Download
Attaching Expected video for reference
Expected_NoWi-FiNetworks.mp4
14.0 MB View Download
Cc: tbuck...@chromium.org
Owner: zork@chromium.org
This delay definitely seems longer in M65 than it does in M63. @zork, could we set it to hide the list instantly when the toggle is switched off?

Comment 3 by zork@chromium.org, Jan 25 2018

Cc: zork@chromium.org
Owner: x...@chromium.org
That seems like a reasonable solution.

Daisy, could you have someone look into this?

Comment 4 by x...@chromium.org, Jan 25 2018

Cc: xiaoyinh@chromium.org
xiaoyinh@, could this issue be related to your change?
My recent CL to change the update frequency is for the bluetooth tray. This bug is about the network list, so it's probably irrelevant. Looking at the code, it feels like it takes sometime to disable the wifi and receive a networkStateChanged event. 

I think we can fix this by hide the network list immediately when the toggle is off. 

Comment 6 by x...@chromium.org, Jan 25 2018

Thanks! If it's a simple fix, could you help take a look at it since you've been very familiar with this part of codes?
Owner: xiaoyinh@chromium.org
Sure. Assigning to myself.
Labels: Inhouse-HYD-Reported
Any update on this?

This is marked as release block stable for 65, so we need a fix in the next couple weeks.
Sorry I've been busy with other tasks, will take a close look today.
Somehow I couldn't repro on ToT: the label "Wi-Fi is turned off" shows after ~1s without any Wi-Fi networks. 
Looks like 1s comes from the update frequency in TrayNetworkStateObserver.
I've uploaded a CL to update immediately when wifi becomes disabled. 
In addition, we don't need to show wifi network list when it's disabled.

https://chromium-review.googlesource.com/c/chromium/src/+/936003

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ef07e85110f261574c300e8c236274ea05797f

commit 50ef07e85110f261574c300e8c236274ea05797f
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Feb 26 22:26:38 2018

Update wifi network immediately when it's disabled

Bug:  798325 
Change-Id: Icc0e4a8e6e61b01e5736d52e65632b3e47a1f0d6
Reviewed-on: https://chromium-review.googlesource.com/936003
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539290}
[modify] https://crrev.com/50ef07e85110f261574c300e8c236274ea05797f/ash/system/network/network_list.cc
[modify] https://crrev.com/50ef07e85110f261574c300e8c236274ea05797f/ash/system/network/tray_network_state_observer.cc
[modify] https://crrev.com/50ef07e85110f261574c300e8c236274ea05797f/ash/system/network/tray_network_state_observer.h

Labels: Merge-Request-65
Project Member

Comment 15 by sheriffbot@chromium.org, Feb 26 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 28 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dfbcb4816fccd178cef5ab6a70fa3a99e6c57ef

commit 5dfbcb4816fccd178cef5ab6a70fa3a99e6c57ef
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Feb 28 02:47:28 2018

[Merge to M65]Update wifi network immediately when it's disabled

TBR=stevenjb@chromium.org
(cherry picked from commit 50ef07e85110f261574c300e8c236274ea05797f)

Bug:  798325 
Change-Id: Icc0e4a8e6e61b01e5736d52e65632b3e47a1f0d6
Reviewed-on: https://chromium-review.googlesource.com/936003
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#539290}
Reviewed-on: https://chromium-review.googlesource.com/940767
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#621}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/5dfbcb4816fccd178cef5ab6a70fa3a99e6c57ef/ash/system/network/network_list.cc
[modify] https://crrev.com/5dfbcb4816fccd178cef5ab6a70fa3a99e6c57ef/ash/system/network/tray_network_state_observer.cc
[modify] https://crrev.com/5dfbcb4816fccd178cef5ab6a70fa3a99e6c57ef/ash/system/network/tray_network_state_observer.h

Status: Fixed (was: Assigned)
Cc: r...@chromium.org

Sign in to add a comment