New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798319 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3%-17.3% regression in smoothness.tough_animation_cases at 526062:526141

Project Member Reported by alexclarke@chromium.org, Jan 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=798319

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f156013ef0fd9f8f2c177d4942a6f8fbe58ccfd50a7c60b32ad6131d8e808fe4


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus7v2
android-webview-nexus6
chromium-rel-mac11
Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Xianzhu Wang
  Commit : 1de7bf475012870fbc4cb27aac5f2206444f5fe3
  Date   : Sat Dec 23 01:10:14 2017
  Subject: [SPv175+] Cache fragmented display items and paint chunks

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : smoothness.tough_animation_cases
  Metric       : frame_times/balls_css_transition_2_properties.html
  Change       : 17.57% | 161.613776062 -> 190.002076717

Revision             Result                  N
chromium@526095      161.614 +- 8.21079      6      good
chromium@526107      163.735 +- 14.6479      6      good
chromium@526113      162.204 +- 5.31301      6      good
chromium@526116      167.647 +- 10.6725      6      good
chromium@526117      162.788 +- 12.9903      6      good
chromium@526118      184.931 +- 11.4362      6      bad       <--
chromium@526140      190.002 +- 15.1162      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=balls.css.transition.2.properties.html smoothness.tough_animation_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958520561092798656


For feedback, file a bug with component Speed>Bisection
 Issue 798342  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a82cda4f10516c1da1fcb990a6a33146660448b

commit 7a82cda4f10516c1da1fcb990a6a33146660448b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Jan 03 21:13:08 2018

[PE] Fix performance regression crrev.com/c/841542

Use template instead of std::function parameter to ensure ForAllFragments
is properly inlined on all platforms.

Bug:  798319 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iaebe282640a07bf2667be7647bb875fcbb1c77f5
Reviewed-on: https://chromium-review.googlesource.com/846250
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526815}
[modify] https://crrev.com/7a82cda4f10516c1da1fcb990a6a33146660448b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Components: Blink>Paint
Status: Fixed (was: Assigned)
Performance is not only recovered, but also better than before :)

Sign in to add a comment