New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798308 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8% regression in system_health.memory_mobile at 525249:525301

Project Member Reported by alexclarke@chromium.org, Jan 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=798308

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3982714354d29816bcc9a8dffc0327d5a792d1ff6a89870a3af406a8b5d01696


Bot(s) for this bug's original alert(s):

android-webview-nexus5X

=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:proportional_resident_size_avg/load_search/load_search_yahoo

Revision             Result                   N
chromium@525248      93149090 +- 1609492      21      good
chromium@525301      93362667 +- 1690425      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.yahoo system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958520851615043824


For feedback, file a bug with component Speed>Bisection
Cc: yangguo@chromium.org
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author yangguo@chromium.org ===

Hi yangguo@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Yang Guo
  Commit : 9c6bc7afc0f8a62e24df92d72e41f2f9d590e023
  Date   : Wed Dec 20 07:34:39 2017
  Subject: Leave spaces between instance types.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:proportional_resident_size_avg/load_search/load_search_yahoo
  Change       : 1.73% | 92869058.6667 -> 94474170.6667

Revision                           Result                   N
chromium@524500                    92869059 +- 881640       6      good
chromium@524950                    92723309 +- 962053       6      good
chromium@525175                    93413989 +- 557802       6      good
chromium@525288                    93592108 +- 1336202      9      good
chromium@525344                    93550807 +- 1029337      9      good
chromium@525344,v8@9c6bc7afc0      94664293 +- 733889       6      bad       <--
chromium@525344,v8@c293bc010b      94925243 +- 1114501      6      bad
chromium@525344,v8@bf691e79d7      94899813 +- 446646       6      bad
chromium@525345                    94809872 +- 353189       6      bad
chromium@525346                    94729317 +- 425160       6      bad
chromium@525348                    94998971 +- 1124073      6      bad
chromium@525351                    94710885 +- 1326407      6      bad
chromium@525358                    94455227 +- 361252       6      bad
chromium@525372                    94435088 +- 652981       6      bad
chromium@525400                    94474171 +- 775580       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.yahoo system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958416885907029312


For feedback, file a bug with component Speed>Bisection
Status: Fixed (was: Assigned)
This came back down; marking fixed since I know yanggou landed some fixes for memory issues.

Sign in to add a comment