New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798288 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 804145



Sign in to add a comment

RemoveFormat command crahses with display:none and position:relative

Project Member Reported by ClusterFuzz, Jan 2 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5364744159756288

Fuzzer: attekett_dom_fuzzer
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  chrome
  blink::IsTabHTMLSpanElement
  blink::ApplyStyleCommand::RemoveCSSStyle
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=523197:523221

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5364744159756288

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: kkaluri@chromium.org
Components: Blink>Editing>Command
Labels: M-65 Test-Predator-Wrong
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "EditingUtilities.cpp" assigning to the concern owner who might be related.

Suspect CL: https://chromium.googlesource.com/chromium/src/+/52d55d36c78e4772e0e3499409dc6f6dcabde00e

yosin@ -- Could you please look into the issue, kindly assign it to concern owner.


Thank You.

Comment 2 by yosin@chromium.org, Jan 10 2018

Labels: Pri-3

Comment 3 by yosin@chromium.org, Jan 11 2018

Owner: ----
Status: Available (was: Assigned)
Summary: RemoveFormat command crahses with display:none and position:relative (was: Null-dereference READ in chrome)
Pri-3 since real world usage of removeFormat command with unusual HTML is low
Owner: tanvir.r...@samsung.com
Status: Assigned (was: Available)
Blockedon: 804145
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb4bc15031c85102d75b6819fe64cec85c8a04a

commit 4bb4bc15031c85102d75b6819fe64cec85c8a04a
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Wed Jan 24 10:15:43 2018

Fix for crash in IsTabHTMLSpanElement

Crash in EditingUtilities IsTabHTMLSpanElement
when style has display:none, as display:none
makes the computedStyle for <span> as nill.
Added safety check to avoid this scenario.

Bug:  798288 
Change-Id: I3953959d8e1f2067f48d9c064b32c889842b3e49
Reviewed-on: https://chromium-review.googlesource.com/877739
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#531492}
[modify] https://crrev.com/4bb4bc15031c85102d75b6819fe64cec85c8a04a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/4bb4bc15031c85102d75b6819fe64cec85c8a04a/third_party/WebKit/Source/core/editing/EditingUtilities.h
[modify] https://crrev.com/4bb4bc15031c85102d75b6819fe64cec85c8a04a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Project Member

Comment 7 by ClusterFuzz, Jan 25 2018

ClusterFuzz has detected this issue as fixed in range 531487:531495.

Detailed report: https://clusterfuzz.com/testcase?key=5364744159756288

Fuzzer: attekett_dom_fuzzer
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  chrome
  blink::IsTabHTMLSpanElement
  blink::ApplyStyleCommand::RemoveCSSStyle
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=523197:523221
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=531487:531495

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5364744159756288

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jan 25 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5364744159756288 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment