New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798279 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

3%-22.6% regression in speedometer2 at 526209:526235

Project Member Reported by hablich@chromium.org, Jan 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=798279

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=49c8c3d6b7f31338b9f1d229b7b19e75306cb799e4e1d22cc8668e71c19e8374


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus6
android-nexus7v2
android-one
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
win-high-dpi
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14db1c4d040000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14b53d03040000
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12cf386d040000
Cc: adithyas@chromium.org
I think based on https://pinpoint-dot-chromeperf.appspot.com/job/14db1c4d040000, 
https://crrev.com/d5fbf7c5c3f8f9b46b75f674771f3533c7e3e24d is the culprit. I was able to reproduce the regression locally as well. 
Cc: ahaas@chromium.org
Owner: fran...@chromium.org
Status: Assigned (was: Untriaged)
Franzi, can you please investigate?
Labels: -Pri-2 ReleaseBlock-Beta Pri-1
Sorry about that, seems likely that the interceptor change causes performances regressions. I reverted the CL for now since it's a blocker and we'll investigate.
Please add affected OSs.
 Issue 798286  has been merged into this issue.
Labels: OS-Linux OS-Mac OS-Windows
franzih@ Ping! This issue is marked as RB-Beta, could you please let us know is there any latest update available on this issue?
I reverted the problematic commit last week, it's in 65. https://chromium.googlesource.com/v8/v8/+/971875ca4d4ff82bc93fa906eb58a208fa9a3eeb

This should have fixed the performance regression.
franzih@ If this issue is fixed completely, could you please change the status of the bug.

Thanks!
Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Per comment #17, this change is already in M65. No merge is needed.
Cc: timothygu@chromium.org

Sign in to add a comment