New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798231 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Remove dead code from master_flake_analysis

Project Member Reported by lijeffrey@chromium.org, Jan 2 2018

Issue description

Once switch is flipped for build level to commit position analysis only, remove dead code from master_flake_analysis

1. GetDataPointsWithinCommitPositionRange
2. GetDataPointsWithinBuildNumberRange
3. GetDataPointOfSuspectedBuild

 
Blocking: 782434
estimate: 0.1 days
Blocking: -782434
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/44772651fc27c1e33bba88741f461b62a491ac5e

commit 44772651fc27c1e33bba88741f461b62a491ac5e
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Oct 08 18:09:39 2018

[Findit] Flake Analyzer - Cleaning up dead code in MasterFlakeAnalysis

No functional changes - all code removed has been dead since migrating
to the new pipelines.

Bug:  839620 , 798231
Change-Id: I71328173880922b6281aa1c13cfdcaf4f535d289
Reviewed-on: https://chromium-review.googlesource.com/c/1262921
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18148}
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/test/master_flake_analysis_test.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/flake_swarming_task.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/master_flake_analysis.py

Sign in to add a comment