Should not offer to restore tabs when there's nothing to restore |
||
Issue descriptionGoogle Chrome 64.0.3282.41 (Official Build) beta (64-bit) Revision 0 Platform 10176.22.0 (Official Build) beta-channel eve What steps will reproduce the problem? (1) Leave computer off for a while. (2) Turn it on. What is the expected result? Should not show a popup to restore tabs. When I click restore nothing happens since there's actually no tabs to restore. What happens instead? Shows a tab restore popup even though there's nothing to restore. Instead it should check to see if there's actually tabs to restore first before showing the popup.
,
Jan 2 2018
Years ago msw implemented this, and I thought we checked whether there was a previous session before doing it. Mike, any comments?
,
Jan 2 2018
I updated the bubble, but don't recall any session restore details offhand, sorry. Does this bubble showing mean that Chrome crashed on step 1? Looks like the logic to show the bubble is here: https://cs.chromium.org/chromium/src/chrome/browser/ui/startup/startup_browser_creator_impl.cc?rcl=1c2e7d2c670b522c26cb82bc5c8a15fbf57beb59&l=775 (aside: looks like SessionCrashedBubble::Show always returns true, line 777 may never run?) |
||
►
Sign in to add a comment |
||
Comment 1 by sky@chromium.org
, Jan 2 2018