New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798226 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 655359
Owner:
Last visit > 30 days ago
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

New context menu doesn't have always header

Project Member Reported by mar...@mwiacek.com, Jan 2 2018

Issue description

Steps to reproduce the problem:
1. Open new context menu for some elements 

What is the expected behavior?
New context menu has got some header and nice view

What went wrong?
In extreme situation we get only one menu option, which doesn't look very good

Did this work before? No 

Chrome version: 65.0.3309.0  Channel: canary
OS Version: 7
Flash Version: 

It's more FE than real bug.
 
Screenshot_20180101-124248.png
629 KB View Download
Screenshot_20180101-124130.png
909 KB View Download
Labels: Needs-triage-Mobile
Cc: k...@chromium.org pnangunoori@chromium.org
Components: UI>Browser>Core
Labels: M-65 Triaged-Mobile
Status: Untriaged (was: Unconfirmed)
Tested the issue in Android and could reproduce the issue.

Steps Followed:
1. Launched Chrome .
2. Navigated to the URL: m.demotywatory.pl/4821952
3. Long tap on the video.
4. Observed that the menu displayed is not similar to the context menu displayed for other images i.e. without headers and other menu options.

Note: Enabled the flag #enable-custom-context-menu

Chrome versions tested:
65.0.3309.0

OS
Android 8

Android Devices
Pixel 2

Considering this issue as Non-Regression issue and marking this issue as Untriage and CC'ing the dev.

Please navigate to below link for log's and video--
go/chrome-androidlogs/798226

Thanks!
798226.png
472 KB View Download
Note: For few other videos, proper Context Menu is displayed. Attached reference screenshot in C#2.

Comment 4 by k...@chromium.org, Jan 2 2018

I'm guessing this happens when a video is also a link or not. If a video is just a video, the only action I believe we have now is download video as there isn't any other that make sense.

Comment 5 by mar...@mwiacek.com, Jan 2 2018

Please refer to #0, where it's written: "New context menu doesn't have always header" and "It's more FE than real bug.".

Displaying always header is IMHO very good change and nothing less / nothing more was reported.
Cc: danielpark@chromium.org
Labels: android-fe-triaged
Owner: hannahs@chromium.org
Status: Assigned (was: Untriaged)
Over to hannahs@ to consider this feedback for UX design. Please close out if this is working as intended.

I think this is working correctly, per the current UX spec. We only display the header if there are both LINK and IMAGE options.

Comment 7 by k...@chromium.org, Feb 15 2018

Cc: -k...@chromium.org
Mergedinto: 655359
Status: Duplicate (was: Assigned)

Sign in to add a comment