New issue
Advanced search Search tips

Issue 798208 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Abrt in sk_abort_no_print

Project Member Reported by ClusterFuzz, Jan 1 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5534331882962944

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e9000015f7
Crash State:
  sk_abort_no_print
  SkGradientShaderBase::SkGradientShaderBase
  SkGradientShaderBase::SkGradientShaderBase
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=522280:522310

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5534331882962944

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 1 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 1 2018

Labels: Test-Predator-Auto-Owner
Owner: reed@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/fadbfcd4aba676d44dfb08de1a83143a1c63b95c (upgrade SkReadBuffer to always validate).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by reed@chromium.org, Jan 2 2018

Cc: brianosman@chromium.org mtklein@chromium.org reed@google.com
Owner: fmalita@chromium.org
This is from a fuzzer, but the cause/fix are likely not deserialization specific:

If we still have (some) restrictions on colorspace for gradients, we should perform that accept/reject in the factories (i.e. MakeLinear, MakeRadial, etc.).

Comment 4 by enne@chromium.org, Apr 26 2018

Labels: -Pri-1 Pri-2
With respect to being a security issue, I don't think this bug needs to be fixed so downgrading to a P2.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/abc8575380e031c476fec6791df4bfb3244ea928

commit abc8575380e031c476fec6791df4bfb3244ea928
Author: Florin Malita <fmalita@chromium.org>
Date: Thu Apr 26 13:50:13 2018

Remove stale gradient color space assert

SkGradientShaderBase asserts gammaIsLinear() -- but we don't enforce
this in factories.

Based on comments, this may be a stale restriction.  Can we drop it?

Bug:  chromium:798208 
Change-Id: Id9639cb2bb87f112b26c05372f2a3181c139e5ec
Reviewed-on: https://skia-review.googlesource.com/123860
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

[modify] https://crrev.com/abc8575380e031c476fec6791df4bfb3244ea928/src/shaders/gradients/SkGradientShader.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11ad0acb7e6af1dee8fb4a69e54871a15ae4d26f

commit 11ad0acb7e6af1dee8fb4a69e54871a15ae4d26f
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 16:47:11 2018

Roll src/third_party/skia/ 1178ea0f7..c79e2d155 (3 commits)

https://skia.googlesource.com/skia.git/+log/1178ea0f7b11..c79e2d155151

$ git log 1178ea0f7..c79e2d155 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 liyuqian Check negative width before blitAntiRect
2018-04-25 fmalita Remove stale gradient color space assert
2018-04-25 xster Add more granularity inside of SkCanvas::Flush traces.

Created with:
  roll-dep src/third_party/skia
BUG= chromium:798208 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I94acf81be1b0d7aba0370bfb2edef90303b4e5b8
Reviewed-on: https://chromium-review.googlesource.com/1030610
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554053}
[modify] https://crrev.com/11ad0acb7e6af1dee8fb4a69e54871a15ae4d26f/DEPS

Project Member

Comment 8 by ClusterFuzz, Apr 27 2018

ClusterFuzz has detected this issue as fixed in range 554048:554059.

Detailed report: https://clusterfuzz.com/testcase?key=5534331882962944

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390000083e
Crash State:
  sk_abort_no_print
  SkGradientShaderBase::SkGradientShaderBase
  SkGradientShaderBase::SkGradientShaderBase
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=522280:522310
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=554048:554059

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5534331882962944

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Apr 27 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5534331882962944 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment