Auto margins cause width bug within flexbox on browser resize
Reported by
drew.mcm...@bbc.co.uk,
Dec 31 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3309.0 Safari/537.36 Steps to reproduce the problem: 1. Open https://codepen.io/drewmcmillan/pen/KZmoeW 2. Open to a width >700px 3. Resize screen to a width of < 500px 4. See that text hangs off the screen 5. Refresh the page 6. See that the text is now shown correctly What is the expected behavior? The text should resize to fit the screen automatically on resize This works in: Firefox 57.0.3 Safari 10.1.2 (12603.3.8) What went wrong? It didn't resize correctly. Requires a page refresh (which shouldn't be needed in CSS) Did this work before? N/A Does this work in other browsers? Yes Chrome version: 65.0.3309.0 Channel: canary OS Version: OS X 10.12.6 Flash Version: https://codepen.io/drewmcmillan/pen/KZmoeW
,
Jan 2 2018
Can reproduce on 63.0.3239.84 (Official Build) (64-bit). Shrinking the window width to < 500px causes text to be cut off. Refreshing fixes this. However, can't reproduce on 65.0.3306.0 (Official Build) canary (64-bit). Request reverse bisect to see what patch fixed this issue. Also redirecting to layout as it seems more like a text layout issue.
,
Jan 3 2018
Able to reproduce the issue on chrome version 63.0.3239.84 and the same is not seen on latest canary 64.0.3309.0 and beta 64.0.3282.39 using Windows 10, Ubuntu 14.04, Mac 10.12.6 hence providing reverse bisect info Reverse Bisect Info: ================ Last Bad build: 64.0.3259.0 First Good build: 64.0.3260.0 You are probably looking for a change made after 514041 (known good), but no later than 514042 (first known bad). https://chromium.googlesource.com/chromium/src/+log/a3c63f7c118585fbcdd85083a5ba75781459f92f..d84d88fc4d3223c89148ef62bc2785410e77fa2e Reviewed on: https://chromium-review.googlesource.com/751262 @Javier Fernandez: Please confirm the issue and help in re-assigning if it is not related to your change, help in mergign this issue to M-63 if applicable Adding ReleaseBlock-Stable as it seems recent break, feel free to remove it if not applicable. Thanks!
,
Jan 3 2018
,
Jan 8 2018
This is issue has been flagged as a regression, but it's not, if I understood it correctly. Do we really want to merge a fix from trunk in M63 ? My patch only touches Grid Layout's logic, so if it solves an issue, it's one quite specific (flexbox as grid item). I don't understand why this issue is a release blocker, but the patch is easy enough to be confident on merging it in M63 if we really want to.
,
Jan 8 2018
No we don't, thanks jfernandez! Marking as fixed and *not* requesting merge.
,
Jan 8 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Jan 11 2018
Removing "Merge-TBD" label as no merge is needed per comment #6. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by krajshree@chromium.org
, Jan 1 2018