Clicking on the title bar does not blur the Omnibox
Reported by
andras.b...@betavr.com,
Dec 31 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. Start typing something in the Omnibox. 2. Use the mouse to click on an empty space in the window 's titlebar. 3. Observe how the Omnibox stays open. What is the expected behavior? Omnibox dropdown should be closed when a mouse click is detected on the title bar or the frame of the window. What went wrong? The Omnibox dropdown doesn't close when the browser window's title bar, or frame is clicked. Did this work before? Yes I can't remember Chrome version: 63.0.3239.84 Channel: n/a OS Version: 10.0 Flash Version: This is problematic because the user may want to access the bookmarks bar, which is covered by the Omnibox dropdown. Currently to close the dropdown, the user needs to click somewhere inside the displayed website, which may trigger an unwanted action on the website.
,
Jan 3 2018
Looks like it's working to me. The title bar isn't a focus point. Try clicking on a grayed out forward or backward arrow; nothing happens. But click in the window contents and the focus transfers there and the pop-up closes. Note that _double_ clicking the title bar will adjust the size of the window and close the pop-up. Perhaps this is what you recall?
,
Jan 4 2018
The title is incorrect, it should be "Clicking on the title bar does not close the Omnibox dropdown". Focus has nothing to do with this issue at all.
,
Jan 4 2018
The alternate title might be a better description of the symptom, but the mechanism is still focus. The Omnibox closes the pop-up on several events, one of them blurring, which you can see in ::OnBlur(). The Omnibox is clearly not getting a blur event when the title bar is clicked, and I don't know why it would.
,
Jan 4 2018
Why is it not possible to mimic the behaviour of the ESC key? That way the focus can stay in the address bar, while the dropdown is being closed. Win win.
,
Jan 5 2018
Two thoughts: On Mac (I don't know about Windows), you can drag the window using the gray space on the title bar. Sometimes I do so. I wouldn't want the omnibox to close because of this. Also, sometimes I rearrange tabs by dragging the title bar, and sometimes I do this while typing in the omnibox (so the place I'm going to navigate to is next to a relevant tab). So if you want to do this, you'd have to do it carefully: clicks in the gray bar should close the omnibox, but drags should not. I also think clicks on the title part of the current tab should not close the omnibox either. Generally, I'm inclined to say this is too much complexity and leave the current behavior as-is.
,
Jan 5 2018
,
Jan 31 2018
To make the drop-down close, you could click on another tab or, even better if you're trying to open a bookmark, a new tab. Seems WAI to me.
,
Mar 22 2018
I must disagree. The user should always be able to use the bookmark bar without leaving the currently open tab, whether the suggestions dropdown is open or not. Why restrict user behavior? Also it isn't impossible, but less than trivial to close the dropdown. It is achievable by: - doubleclicking on the title bar (which maximizes or restores the window) - clicking the maximize or restore button - moving the window - resizing the window - pressing ESC on the keyboard Single clicking on the titlebar would be the most logical way to do this. But even single clicking on the tab would be better than the 5 listed solutions. Also if you're not comfortable with these because of inconsistency between window managers on different platforms, why not put a button on the dropdown that makes it roll up? |
||||
►
Sign in to add a comment |
||||
Comment 1 by sc00335...@techmahindra.com
, Jan 1 2018Components: -UI UI>Browser>Omnibox>ZeroSuggest
Labels: -Type-Bug-Regression Triaged-ET M-65 Needs-Triage-M63 OS-Linux OS-Mac Type-Bug
Status: Untriaged (was: Unconfirmed)
605 KB
605 KB View Download