New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798182 link

Starred by 2 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Jan 2018
Cc:
█ abdulsyed@chromium.org
pdr@chromium.org
█ manoranj...@chromium.org
pbomm...@chromium.org
█ sc00335...@techmahindra.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Drag ghost image is cropped when the dragged element is translated.

Reported by simon.ve...@gmail.com, Dec 31 2017 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Example URL:
https://codepen.io/simonverreydt/pen/opWmNz

Steps to reproduce the problem:
1. Scroll to the bottom of the viewport
2. Start dragging the pink square

What is the expected behavior?

What went wrong?
The pink square ghost image is cropped

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 63.0.3239.84  Channel: n/a
OS Version: 10.0
Flash Version: 

The cropping does seems to not happen if :
- The CSS transform is removed on #inner OR
- The viewport is not scrolled

Comment 1 by sc00335...@techmahindra.com, Jan 1 2018

Cc: chrishtr@chromium.org sc00335...@techmahindra.com
Components: Blink>DataTransfer
Labels: -Pri-2 -Type-Compat hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-63 Needs-Triage-M63 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: pdr@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 63.0.3239.84,on latest stable 63.0.3239.108 and on canary 65.0.3309.0 on windows 10, Ubuntu 14.04 and Mac 10.13.1. Ghost image is not seen on dragging pink square. 

Good Build: 63.0.3222.0
Bad Build: 63.0.3223.0

You are probably looking for a change made after 503942 (known good), but no later than 503943 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/717cd5747ed764a9268c6b9538a9c51f8d73ab93..3feb9fd8645d6d4d1cda73ea7ac6569aeb834551

Reviewed-on: https://chromium-review.googlesource.com/671166

Suspecting same from changelog.

@pdr: Please feel free to re-assign if it is not related to your change. Adding RB-Stable for M-63. Please remove if not the case.

cc'ing reviwer @chrishtr as pdr is OOO till march.

Thanks!

Comment 2 by pbomm...@chromium.org, Jan 2 2018

Cc: -chrishtr@chromium.org pbomm...@chromium.org pdr@chromium.org abdulsyed@chromium.org manoranj...@chromium.org
Labels: M-64 Target-65 FoundIn-64 FoundIn-65 Target-64
Owner: chrishtr@chromium.org
Assigning to Chris since Philip is on vacation.

Comment 3 by chrishtr@chromium.org, Jan 2 2018 

Oddly, I can reproduce this at ToT even with the CL referenced in comment 1 reverted.

Comment 4 by chrishtr@chromium.org, Jan 3 2018

Labels: -M-63 -Target-65 FoundIn-63
This doesn't need to block 63, but a fix should be mrged to 64.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b3d20c33f49cc89d8f0b0c62cf93fde4675407

commit 16b3d20c33f49cc89d8f0b0c62cf93fde4675407
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Jan 03 22:14:33 2018

Clip dragged images before calling CreateDragImageForFrame.

Also, pass the paint offset independently of the bounds.
The two callsites of CreateDragImageForFrame paint in different
coordinate spaces. Also, the callsite in DragController is already
clipping.

This fixes two issues: that the bounds rect did not match the
coordinate space of the clip applied in CreateDragImageForFrame,
and that the coordinate space is not necessarily the LayoutView.

Bug:  798182 
Change-Id: Ie792095806613cd1e6238bbb0d1b8335350ede01
Reviewed-on: https://chromium-review.googlesource.com/848499
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526835}
[modify] https://crrev.com/16b3d20c33f49cc89d8f0b0c62cf93fde4675407/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/16b3d20c33f49cc89d8f0b0c62cf93fde4675407/third_party/WebKit/Source/core/clipboard/DataTransfer.h
[modify] https://crrev.com/16b3d20c33f49cc89d8f0b0c62cf93fde4675407/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
[modify] https://crrev.com/16b3d20c33f49cc89d8f0b0c62cf93fde4675407/third_party/WebKit/Source/core/page/DragController.cpp

Comment 6 by chrishtr@chromium.org, Jan 3 2018

Labels: Merge-Request-64
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 4 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by abdulsyed@google.com, Jan 5 2018 

Is this well tested in Canary and Dev? Can you please confirm if this is a safe merge overall? We are only a few weeks away from stable.

Comment 9 by chrishtr@chromium.org, Jan 5 2018 

It is tested in Canary and Dev, and works correctly. The fix is safe.

Comment 10 by chrishtr@chromium.org, Jan 8 2018 

Pinging this thread.  crbug.com/798704  was approved for M64 merge, but actually
builds on the CL fixing this bug. May I also merge this one?

Comment 11 by abdulsyed@google.com, Jan 9 2018

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge for M64. Branch:3282
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ec59c74336a435a027dda74da9be13c95e0453

commit f4ec59c74336a435a027dda74da9be13c95e0453
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Jan 09 19:19:29 2018

Clip dragged images before calling CreateDragImageForFrame.

Also, pass the paint offset independently of the bounds.
The two callsites of CreateDragImageForFrame paint in different
coordinate spaces. Also, the callsite in DragController is already
clipping.

This fixes two issues: that the bounds rect did not match the
coordinate space of the clip applied in CreateDragImageForFrame,
and that the coordinate space is not necessarily the LayoutView.

TBR=chrishtr@chromium.org

(cherry picked from commit 16b3d20c33f49cc89d8f0b0c62cf93fde4675407)

Bug:  798182 
Change-Id: Ie792095806613cd1e6238bbb0d1b8335350ede01
Reviewed-on: https://chromium-review.googlesource.com/848499
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#526835}
Reviewed-on: https://chromium-review.googlesource.com/857883
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#464}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/f4ec59c74336a435a027dda74da9be13c95e0453/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/f4ec59c74336a435a027dda74da9be13c95e0453/third_party/WebKit/Source/core/clipboard/DataTransfer.h
[modify] https://crrev.com/f4ec59c74336a435a027dda74da9be13c95e0453/third_party/WebKit/Source/core/clipboard/DataTransferTest.cpp
[modify] https://crrev.com/f4ec59c74336a435a027dda74da9be13c95e0453/third_party/WebKit/Source/core/page/DragController.cpp

Comment 13 by chrishtr@chromium.org, Jan 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment