New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798176 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit 16 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

NEEDS_MINIMIZATION InsertUnorderedList command crashes

Project Member Reported by ClusterFuzz, Dec 31 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5441234708725760

Fuzzer: bj_broddelwerk
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::TextIteratorAlgorithm<class blink::EditingAlgorithm<class blink::NodeTrav
  blink::TextIteratorAlgorithm<class blink::EditingAlgorithm<class blink::NodeTrav
  blink::CompositeEditCommand::MoveParagraphs
  
Sanitizer: address (ASAN)

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5441234708725760

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: pnangunoori@chromium.org
Components: Blink
Labels: M-64 Test-Predator-Wrong
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “TextIterator.cpp” assigning to concern owner from GIT blame.
Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/c8070f461957f5f2aaaf41147538ebe811b4abce

@xiaochengh  -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thank You.

Components: -Blink Blink>Editing
Components: -Blink>Editing Blink>Editing>Command
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: NEEDS_MINIMIZATION InsertUnorderedList command crashes (was: Null-dereference READ in blink::TextIteratorAlgorithm<class blink::EditingAlgorithm<class blink::NodeTrav)
Lower to P3 due to low usage of InsertUnorderedListCommand
Owner: tanvir.r...@samsung.com
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7ece4a8392ad07bcbd813dd01c3641d58781388

commit a7ece4a8392ad07bcbd813dd01c3641d58781388
Author: tanvir.rizvi <tanvir.rizvi@samsung.com>
Date: Wed Jan 10 09:17:08 2018

InsertListCommand crash while cleanup

InsertListCommand tries to clean the destination
node during one scenario, when on the
table element webkit-appearance property is
applied.
Because of this DCHECK is reached.

Bug:  798176 
Change-Id: Id5c60e2cf4c8b95c746456d663aacea2f64d07ab
Reviewed-on: https://chromium-review.googlesource.com/856416
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#528266}
[modify] https://crrev.com/a7ece4a8392ad07bcbd813dd01c3641d58781388/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/a7ece4a8392ad07bcbd813dd01c3641d58781388/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

Project Member

Comment 6 by ClusterFuzz, Jan 11 2018

ClusterFuzz has detected this issue as fixed in range 528265:528270.

Detailed report: https://clusterfuzz.com/testcase?key=5441234708725760

Fuzzer: bj_broddelwerk
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  blink::TextIteratorAlgorithm<class blink::EditingAlgorithm<class blink::NodeTrav
  blink::TextIteratorAlgorithm<class blink::EditingAlgorithm<class blink::NodeTrav
  blink::CompositeEditCommand::MoveParagraphs
  
Sanitizer: address (ASAN)

Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=528265:528270

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5441234708725760

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jan 11 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5441234708725760 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment