New issue
Advanced search Search tips

Issue 798173 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkMatrix::postConcat

Project Member Reported by ClusterFuzz, Dec 31 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5254093856833536

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  TwoPointConicalEffect::Data::Data
  Gr2PtConicalGradientEffect::Make
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=525781:525806

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5254093856833536

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 31 2017

Labels: M-65 ReleaseBlock-Beta ClusterFuzz-Top-Crash
Testcase 5254093856833536 is a top crash on ClusterFuzz for linux platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 2 by ClusterFuzz, Dec 31 2017

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Dec 31 2017

Labels: Test-Predator-Auto-Owner
Owner: liyuqian@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/915817b940b05882d85c220d2b2dc18ef184a6b4 (Guard the sqrt(temp) where temp < 0 in 2pt conical gradient).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 31 2017

Labels: Pri-1
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e2d4e8f276ba8aee57f071e87e85f04a6a07addf

commit e2d4e8f276ba8aee57f071e87e85f04a6a07addf
Author: Yuqian Li <liyuqian@google.com>
Date: Tue Jan 02 16:35:40 2018

Stronger fix for swapping r0, r1 in 2pt conical gradients

Bug:  chromium:798173 
Change-Id: I2ac0ee94ecc6230fd450c17b6a0de9065f5b3f16
Reviewed-on: https://skia-review.googlesource.com/90202
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>

[modify] https://crrev.com/e2d4e8f276ba8aee57f071e87e85f04a6a07addf/src/shaders/gradients/SkTwoPointConicalGradient_gpu.cpp

Project Member

Comment 6 by ClusterFuzz, Jan 3 2018

ClusterFuzz has detected this issue as fixed in range 526564:526566.

Detailed report: https://clusterfuzz.com/testcase?key=5254093856833536

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkMatrix::postConcat
  TwoPointConicalEffect::Data::Data
  Gr2PtConicalGradientEffect::Make
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=525781:525806
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=526564:526566

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5254093856833536

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jan 3 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5254093856833536 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 3 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 9 by awhalley@google.com, Jan 26 2018

Labels: -ReleaseBlock-Beta
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 11 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment