Repeating footer may overlap with other rows in a table with cell-spacing or collapsed borders |
||
Issue descriptionI'm working on fragmented paint properties for repeating table headers/footers and played the feature with several test cases in order to understand the current algorithms before duplicating them in PaintPropertyTreeBuilder.cpp (https://chromium-review.googlesource.com/c/chromium/src/+/846504). Kudos to robhogan@ who developed the feature and test cases. Noticed some minor issues with the attached test cases: - repeat-footer1.html: wide cell-spacing - repeat-footer1a.html: wide cell-spacing and table border - repeat-footer2.html: wide collapsed borders All the test cases show repeating footer overlapping with other rows.
,
Dec 30 2017
,
Dec 30 2017
Note that the repeating painting code will be deprecated in slimming paint v175 which will use fragment paint properties for painting. This bug may be mainly for discussion of what the desirable behavior is. Current (repeat-footer1-current.png): This is apparently not desirable. Change1. (repeat-footer1-1.png) Align the repeating footer from the bottom of the fragment with distance = VBorderSpacing: Sometimes the footer may look too close to the row above. Change2. (repeat-footer1-2.png) Align the repeating border at the bottom of the fragment : The footer may look too close to the bottom, but this seems already the behavior of other rows (which may be put with distance from the bottom smaller than VBorderSpacing). Change3. (no mock yet) Always add spacing >= VBorderSpacing between all rows and the border of fragments. This need layout modification to break fragments earlier and add bigger strut before the row after a fragment break. We seem to have already implemented this behavior for repeating headers (which always keep spacing >= VBorderSpacing with fragment borders and other rows). Change3 seems the most desirable to me. |
||
►
Sign in to add a comment |
||
Comment 1 by wangxianzhu@chromium.org
, Dec 30 2017