New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798121 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

"fast/history/history-back-twice-with-subframes-assert.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 29 2017

Issue description

"fast/history/history-back-twice-with-subframes-assert.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRQsSBUZsYWtlIjpmYXN0L2hpc3RvcnkvaGlzdG9yeS1iYWNrLXR3aWNlLXdpdGgtc3ViZnJhbWVzLWFzc2VydC5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: UI>Browser>History UI>Browser>Navigation
Labels: -Sheriff-Chromium OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Owner: tyoshino@chromium.org
Example log: 03:17:31.099 38757 worker/7 fast/history/history-back-twice-with-subframes-assert.html output stderr lines:
03:17:31.099 38757   objc[38808]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Content Shell Framework. One of the two will be used. Which one is undefined.
03:17:31.099 38757   objc[38809]: Class MockCrApp is implemented in both /b/s/w/ir/out/Debug/libtest_runner.dylib and /b/s/w/ir/out/Debug/Content Shell.app/Contents/Frameworks/Content Shell Framework.framework/Content Shell Framework. One of the two will be used. Which one is undefined.
03:17:31.099 38757   [38808:775:0102/031713.393161:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973)
03:17:31.099 38757   [38808:775:0102/031713.393689:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session
03:17:31.099 38757   [38808:775:0102/031713.429061:ERROR:vt_video_encode_accelerator_mac.cc(517)]  VTCompressionSessionCreate failed: -12908
03:17:31.102 36610 [14/17] fast/history/history-back-twice-with-subframes-assert.html failed unexpectedly (test timed out)

Tyoshino: assigning to you as you were the last one to touch that file.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccba8d4045f73a818cf7d57e367e35382c767ba8

commit ccba8d4045f73a818cf7d57e367e35382c767ba8
Author: maxmorin <maxmorin@chromium.org>
Date: Tue Jan 02 14:14:26 2018

back-twice-with-subframes-assert.html flaky.

fast/history/history-back-twice-with-subframes-assert.html flakily
times out.

Bug:  798121 
Change-Id: Idfb693776a84ca1946ec0771fcd2fd2f71a80f10
Tbr: 
Reviewed-on: https://chromium-review.googlesource.com/846990
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526471}
[modify] https://crrev.com/ccba8d4045f73a818cf7d57e367e35382c767ba8/third_party/WebKit/LayoutTests/TestExpectations

Components: -UI>Browser>History -UI>Browser>Navigation Blink>Layout
Labels: android-fe-triaged
UI>Browser>History and UI>Browser>Navigation seem like the incorrect components for flaky webkit test. Please re-add if that's not the case.

Comment 4 by e...@chromium.org, Feb 13 2018

Components: -Blink>Layout Blink>Loader
Flaky tests are assigned to the component they're tested. In this case history navigation.

Blink>Layout is for page layout, not layout tests.
Cc: tyoshino@chromium.org
Labels: -Pri-1 Pri-2
Owner: toyoshim@chromium.org
Status: Assigned (was: Untriaged)
tentatively assigned to me
Components: UI>Browser>History UI>Browser>Navigation
Status: Started (was: Assigned)
This test was introduced at Oct/19/2011.
https://chromium.googlesource.com/chromium/src/+/1a1b55c1bd24579445d40673e0d386904f8225a8

All failures in the record were due to timeout, but test looks it can finish quickly.

Let me just remove the flaky mark and see what happens after that. It this still fails, Navigation members will be better to take a closer look, I think.

Adding History and Navigation components.
fyi, it works fine on local machine, off course.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be06f2f2a79904493976ebca714c33a4e06635ba

commit be06f2f2a79904493976ebca714c33a4e06635ba
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Mar 09 11:46:22 2018

Remove flakiness mark of history-back-twice-with-subframes-assert.html

Since it looks working fine on local machines, and related code base
may be changed day by day for loading and PlzNavigate efforts,
let me just re-enable the test to see what happens.

Bug:  798121 
Change-Id: I07e88b163818019ec340b3aff508191852b7d440
TBR: maxmorin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/956830
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542083}
[modify] https://crrev.com/be06f2f2a79904493976ebca714c33a4e06635ba/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)
no failure in two days

Sign in to add a comment