New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798093 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Gerrit poller is mixing up projects

Project Member Reported by emso@chromium.org, Dec 29 2017

Issue description

After adding Gerrit to tricium-dev the poller sent an Analyze request for a Gerrit change with info about Gerrit files but with playground repo info: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=4229f8e327fbd4db12b2c047214518c1b2df5b21&as=git_file_details.json. 

This caused the git file isolator to fail: https://chromium-swarm.appspot.com/task?id=3abb6331c6c3b010&refresh=10&show_raw=1
 

Comment 2 by emso@chromium.org, Jan 2 2018

From the frontend module log (for the above Git ref):

2017-12-29 14:59:01.570 CET
[frontend] Analyze request (Project: playground-gerrit-tricium, Git ref: refs/changes/91/150291/1)

The gerrit poller is sending analyze requests with the wrong project.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dd456d5cf986098b3becddb1c99c04670a00ccf8

commit dd456d5cf986098b3becddb1c99c04670a00ccf8
Author: Emma <emso@chromium.org>
Date: Tue Jan 02 19:08:55 2018

Extracts Tricium project name earlier.

The project name was extracted after the iteration at the
invocation of the pollProject function, causing the value of 'pd' to be
the same for all projects.

Bug:798093
Change-Id: Ib98dbf2076ddc9557cc26935d8f87463a70a58a7
Reviewed-on: https://chromium-review.googlesource.com/847581
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/dd456d5cf986098b3becddb1c99c04670a00ccf8/go/src/infra/tricium/appengine/gerrit/poll.go

Comment 4 by emso@chromium.org, Jan 4 2018

Status: Fixed (was: Assigned)

Sign in to add a comment