New issue
Advanced search Search tips

Issue 798089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default.html failing on chromium.webkit/WebKit Win10

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 29 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of glider@google.com

virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default.html failing on chromium.webkit/WebKit Win10

Builders failed on: 
- WebKit Win10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10

Suspecting https://chromium.googlesource.com/chromium/src/+/b7e2306fd4d8590a41f6fd103dfcc1013d6ca85e, will try to revert.

I've also seen  issue 773373 , but the test was quite healthy prior to https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/29094, so that seems unrelated. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10d932801bc9e23960f855f2bc4fd9f6a67a5f53

commit 10d932801bc9e23960f855f2bc4fd9f6a67a5f53
Author: Alexander Potapenko <glider@chromium.org>
Date: Fri Dec 29 14:15:06 2017

Revert "[CI] Migrate hit-testing code in PaintLayer to use GeometryMapper."

This reverts commit b7e2306fd4d8590a41f6fd103dfcc1013d6ca85e.

Reason for revert:  crbug.com/798089 , virtual/rootlayerscrolls/fast/scrolling/scrollbar-prevent-default.html failing

BUG= 798089 

Original change's description:
> [CI] Migrate hit-testing code in PaintLayer to use GeometryMapper.
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: If43260c7f32385419a651c8a22e0432d6663cbed
> Reviewed-on: https://chromium-review.googlesource.com/843418
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526345}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Change-Id: Ib2f2928446526fb9a0008be6cd391ad0b84a582c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/846859
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526374}
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/10d932801bc9e23960f855f2bc4fd9f6a67a5f53/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Oh I see. I marked it as Timeout in my patch, whereas it can sometimes timeout and
sometimes fail.
Status: Fixed (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45f384824617447c7e4e8808b4946230dab58e2

commit d45f384824617447c7e4e8808b4946230dab58e2
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sat Dec 30 01:02:37 2017

Revert "Revert "[CI] Migrate hit-testing code in PaintLayer to use GeometryMapper.""

This reverts commit 10d932801bc9e23960f855f2bc4fd9f6a67a5f53, with a one-line change
to TestExpectations. See the difference between patchset 3 and patchset 1.

Bug:  798089 
Tbr: wangxianzhu@chromium.org
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic5a998d5616167c2a1d3ebcd7051812c293b660d
Reviewed-on: https://chromium-review.googlesource.com/846467
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526400}
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/input/GestureManager.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/d45f384824617447c7e4e8808b4946230dab58e2/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

All-Projects-6f1baa2bc3532a55ad8f6a25cbecb64cd44b1ac5.tar.gz
1.6 KB Download

Sign in to add a comment