TranslateTestCase/testTranslateInfobar is flaky on iPad Retina iOS 10.0 |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sdefresne@google.com ios_chrome_external_url_egtests (iPad Retina iOS 10.0) on Mac failing on internal.bling.main/ipad10-simulator Builders failed on: - ipad10-simulator: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad10-simulator The test has been failing intermittently for the last two days.
,
Dec 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eddf23e9ede4271428fbe6e45fce7b31438995a3 commit eddf23e9ede4271428fbe6e45fce7b31438995a3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Dec 29 16:30:36 2017 Wait until translate infobar is presented. The method -simulateTranslationFromSpanishToEnglish was causing flakyness of TranslateTestCase/test{,Incognito}TranslateInfoBar as the presentation of the infobar is animated. The animation is implemented in C++ so EarlGrey cannot synchronize with it. Instead add a method to wait for a matcher to return an element that is sufficiently visible and call it from flaky method to ensure that the element is visible. Use grey_sufficientlyVisible() instead of grey_notNil() in the test as the latter match elements that are outside of the window but grey_tap() cannot tap on them. Re-enable the test as the flakyness has been fixed. Bug: 798063 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1047e2d4780e2f999b51ce3df9f3eaf7daf3e77b Reviewed-on: https://chromium-review.googlesource.com/846746 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526378} [modify] https://crrev.com/eddf23e9ede4271428fbe6e45fce7b31438995a3/ios/chrome/browser/translate/translate_egtest.mm [modify] https://crrev.com/eddf23e9ede4271428fbe6e45fce7b31438995a3/ios/chrome/test/earl_grey/chrome_earl_grey.h [modify] https://crrev.com/eddf23e9ede4271428fbe6e45fce7b31438995a3/ios/chrome/test/earl_grey/chrome_earl_grey.mm
,
Dec 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Dec 29 2017