New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 798062 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Toggle timer button is moving out of pane in Camera App when dragged to LHS

Project Member Reported by kebalaji@chromium.org, Dec 29 2017

Issue description

Chrome Version: 65.0.3299.0/10259.0.0 Blaze, Minnie & Quawks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Open Camera App
(2)Drag the window to LHS Completely and observe

Actual: Toggle timer is moving out of the frame while dragging. Also the Go to gallery button and toggle multishot button are overlapping
Expected: No such issue should be seen.

This is a Non-Regression issue seen from M59.(Camera app is compatible from M59)

@Mtomasz: Please confirm the issue


 
ActualCameraApp.webm
1.4 MB View Download

Comment 1 by y...@chromium.org, Jan 22 2018

Cc: mtomasz@chromium.org
Owner: y...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb

commit 5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb
Author: Yuli Huang <yuli@chromium.org>
Date: Sat Mar 10 08:42:29 2018

Set window's minimum width/height.

BUG= chromium:798062 
TEST=Tested manually on elm.

Change-Id: Ia147044a46da9407bed6d54351c55aea476b8126
Reviewed-on: https://chromium-review.googlesource.com/954810
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb/src/js/background.js

Comment 3 by y...@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
The fix is that the app window now cannot be resized to an unreasonably small size with overlapping buttons. Please verify the fix on the next Camera app canary once it's released.
Still reproducible: Tested on Bob, Eve, Sand with build Chrome OS 10452.19.0/66.0.3359.43 (dev) Feedback ID: Bob-85211434698, Eve-85211430891, Sand-85211598205.

Comment 5 by y...@chromium.org, Mar 21 2018

Which CCA binary you tested on (version/download link)? Please help to attach a repro screenshot. Thanks much. 
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb

commit 5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb
Author: Yuli Huang <yuli@chromium.org>
Date: Sat Mar 10 08:42:29 2018

Set window's minimum width/height.

BUG= chromium:798062 
TEST=Tested manually on elm.

Change-Id: Ia147044a46da9407bed6d54351c55aea476b8126
Reviewed-on: https://chromium-review.googlesource.com/954810
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/5ff3ccd7970b6012e7dc7370da833d4bcf55d2eb/src/js/background.js

Sign in to add a comment