New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 798057 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Feb 2018
Cc:
ajha@chromium.org
abodenha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Delay is seen on opening 'Join Wi-Fi network' overlay in OOBE screen

Project Member Reported by mmanchala@chromium.org, Dec 29 2017 
Chrome Version:  65.0.3299.0/10259.0.0  dev-channel Minnie,Blaze and Quawks 
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> Observe  delay is seen to open 'Join Wi-Fi network' overlay i.e. blank window is seen for few seconds
(Please refer video and Screenshot)

Expected: No delay should be seen to open 'Join Wi-Fi network' overlay i.e. No blank window should be seen on clicking required Wi-Fi network

Actual: Instead delay is seen to open 'Join Wi-Fi network' overlay i.e. blank window is seen for few seconds
 
This is Regression Issue as same is working fine in 65.0.3294.0/10216.0.0 dev-channel Paine

@stevenjb : Please confirm the Issue
Actual_BlankWindowForFewSeconds.mp4
8.6 MB View Download
Expected_NoDelay.mp4
7.0 MB View Download

Comment 1 by mmanchala@chromium.org, Dec 29 2017 

Attavhing Actual Screenshot for reference
Actual_BlankWindowForFewSeconds.jpg
2.9 MB View Download

Comment 2 by steve...@chromium.org, Jan 2 2018

Cc: abodenha@chromium.org tbuck...@chromium.org dpa...@chromium.org
Labels: -Pri-1 Pri-2
The delay appears to be ~1s both times according to the video. This is an unfortunate consequence of using WebUI on slower machines.

I can look into using the same vulcanization mechanism we use for Settings to see if that improves load times.

Comment 3 by steve...@chromium.org, Feb 2 2018

Status: Started (was: Assigned)
Optimizing the webui appears to just about halve the apparent load time (subjectively; it would take a fair bit of effort to measure this objectively). That brings it down to about half a second which is pretty reasonable and feels much better.

CL: https://chromium-review.googlesource.com/c/chromium/src/+/898483
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6246c24a4c587bf985c7424e77ec37de52634e98

commit 6246c24a4c587bf985c7424e77ec37de52634e98
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 08 20:16:00 2018

Optimize chromeos WebUI dialogs

The Chrome OS Settings based WebUI dialogs for configuring networks
and bluetooth devices are fairly complicated. Vulcanizing these
noticably improves load times.

This CL also:
* Moves each dialog to a separate folder including its own BUILD.gn and
  compiled_resources2.gyp files.
* Moves the "optimize_ui" GN define from chrome/common/features.gni to
  ui/base/ui_features.gni
* Uses "optimize_ui" to omit resources in ui/resources/cr_components
  that are only included in files that are optimized.
* Adds some URLSearchParams parsing to support dialogs as tabs for
  debugging.

The net increase to the Resources.pak file is +49K or +0.19%.

Bug:  798057 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I835deccfe7491115c853b698e6a941d7bbd20db8
Reviewed-on: https://chromium-review.googlesource.com/898483
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535487}
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/BUILD.gn
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/browser_resources.grd
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/BUILD.gn
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.js
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/compiled_resources2.gyp
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/compiled_resources2.gyp
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_config_dialog/BUILD.gn
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_config_dialog/compiled_resources2.gyp
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_detail_dialog/BUILD.gn
[add] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_detail_dialog/compiled_resources2.gyp
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.html
[rename] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.js
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/browser/ui/webui/chromeos/internet_detail_dialog.cc
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/common/features.gni
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/test/data/webui/chromeos/cr_onc_strings.js
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/test/data/webui/cr_components/cr_components_browsertest.js
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/ui/base/ui_features.gni
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/ui/resources/BUILD.gn
[modify] https://crrev.com/6246c24a4c587bf985c7424e77ec37de52634e98/ui/webui/resources/cr_components/cr_components_resources.grdp

Comment 5 by steve...@chromium.org, Feb 9 2018

Labels: Merge-Request-65
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 9 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 24 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by bhthompson@google.com, Feb 12 2018 

This is pretty big, have we verified against a canary build that the delay is gone now?

Comment 8 by steve...@chromium.org, Feb 12 2018 

I verified that the dialog loads correctly in about half the time on a device with a local build, but 'coral' is missing in the latest canary builds so I will need to wait to test this there.

Comment 9 by bhthompson@google.com, Feb 13 2018

Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 13 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df4a597ef010752b7d12c33f14cc071300a3db3

commit 0df4a597ef010752b7d12c33f14cc071300a3db3
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Feb 13 19:46:34 2018

Optimize chromeos WebUI dialogs

The Chrome OS Settings based WebUI dialogs for configuring networks
and bluetooth devices are fairly complicated. Vulcanizing these
noticably improves load times.

This CL also:
* Moves each dialog to a separate folder including its own BUILD.gn and
  compiled_resources2.gyp files.
* Moves the "optimize_ui" GN define from chrome/common/features.gni to
  ui/base/ui_features.gni
* Uses "optimize_ui" to omit resources in ui/resources/cr_components
  that are only included in files that are optimized.
* Adds some URLSearchParams parsing to support dialogs as tabs for
  debugging.

The net increase to the Resources.pak file is +49K or +0.19%.

TBR=stevenjb@chromium.org

(cherry picked from commit 6246c24a4c587bf985c7424e77ec37de52634e98)

Bug:  798057 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I835deccfe7491115c853b698e6a941d7bbd20db8
Reviewed-on: https://chromium-review.googlesource.com/898483
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#535487}
Reviewed-on: https://chromium-review.googlesource.com/916888
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#451}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/BUILD.gn
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/browser_resources.grd
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/BUILD.gn
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.html
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/bluetooth_pairing_dialog.js
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/compiled_resources2.gyp
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/compiled_resources2.gyp
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_config_dialog/BUILD.gn
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_config_dialog/compiled_resources2.gyp
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_detail_dialog/BUILD.gn
[add] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_detail_dialog/compiled_resources2.gyp
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.html
[rename] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/resources/chromeos/internet_detail_dialog/internet_detail_dialog.js
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/browser/ui/webui/chromeos/internet_detail_dialog.cc
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/common/features.gni
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/test/data/webui/chromeos/cr_onc_strings.js
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/test/data/webui/cr_components/cr_components_browsertest.js
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/ui/base/ui_features.gni
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/ui/resources/BUILD.gn
[modify] https://crrev.com/0df4a597ef010752b7d12c33f14cc071300a3db3/ui/webui/resources/cr_components/cr_components_resources.grdp
►

Sign in to add a comment