New issue
Advanced search Search tips

Issue 798047 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jul 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert browsing_data to talk to Identity Service client lib

Project Member Reported by blundell@chromium.org, Dec 29 2017 
Should be just talking to IdentityManager rather than SigninManager plus converting associated tests.

Comment 1 by blundell@chromium.org, Dec 29 2017

Blocking: 796544
Components: Internals>Services>Identity
Status: Available (was: Untriaged)

Comment 2 by blundell@chromium.org, Jul 12

Owner: jochen@chromium.org
Status: Assigned (was: Available)
Jochen, interested in taking a look at this? I have a feeling that it might be stale, i.e., in the interim browsing_data's dependencies on //components/signin might have been removed for some other reason.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9159e523ff939514ed3ece9579251432b9bda19c

commit 9159e523ff939514ed3ece9579251432b9bda19c
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Jul 18 08:39:25 2018

Remove stale dependency from browsing_data on signin

BUG= 798047 
R=blundell@chromium.org

Change-Id: I65d98494978b89b496170d7b0e377710892afa45
Reviewed-on: https://chromium-review.googlesource.com/1140064
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575979}
[modify] https://crrev.com/9159e523ff939514ed3ece9579251432b9bda19c/components/browsing_data/core/BUILD.gn
[modify] https://crrev.com/9159e523ff939514ed3ece9579251432b9bda19c/components/browsing_data/core/DEPS

Comment 4 by jochen@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment