Issue metadata
Sign in to add a comment
|
NTP is seen for a second on “FRE” screen |
||||||||||||||||||||||
Issue descriptionApp Version: 65.0.3307.0 canary iOS Version:10.3.3, 11.0.1 Device : iPhones Steps to reproduce : 1. Install and Launch chrome. Observed results: NTP is seen for a second in FRE screen. Expected results: NTR should not be displayed in FRE screen. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No in M63 Bug reproducible on the current beta channel build (App Version, iOS Version): No in M64 Link to video : https://drive.google.com/file/d/1J-4bquGEn9Nbm1BceTMVyo8wKlAb87NM/view?usp=sharing
,
Jan 2 2018
,
Jan 5 2018
,
Jan 25 2018
Also reproducible on iPad on Chrome Beta 65 App Version: Chrome Beta 65.0.3325.16 iOS Version: iOS 10.3.3 Device: iPad Mini, iPad https://drive.google.com/open?id=1Hvhhkw-TksuO2SUZZK0nB1jWxQoNMb1F https://drive.google.com/open?id=1WKqLATBsrt5WSl-Wc6aZSYVY5GDY3TSa
,
Jan 31 2018
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38a8848db004ce5b8c7f2269e1e2e6abca5f2db9 commit 38a8848db004ce5b8c7f2269e1e2e6abca5f2db9 Author: Mark Cogan <marq@google.com> Date: Thu Feb 01 15:43:03 2018 [iOS] Improve fix for NTP flicker during first run. The existing fix for the NTP flickering in when the FRE view is shown doesn't work when the BVC itself is presented. This CL improves that fix by not depending on the BVC's view having a window when -presentViewController:animated: is called. Bug: 798042 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ddb8a1867ff84d15b912e607dfce3f180d011e9 Reviewed-on: https://chromium-review.googlesource.com/895685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#533673} [modify] https://crrev.com/38a8848db004ce5b8c7f2269e1e2e6abca5f2db9/ios/chrome/browser/ui/browser_view_controller.mm
,
Feb 1 2018
,
Feb 1 2018
,
Feb 2 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 6 2018
Verified in: App Version: 66.0.3340.0 canary Devices: iPhone 7 Plus, iPhone 8 Plus, iPad Air iOS Versions: 10.3.3, 11.2.5 Issue is fixed. No flickering when the FRE view is shown.
,
Feb 9 2018
Please merge this as soon as possible.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44da87accde78b29aedb7db1e96602fd4d53d625 commit 44da87accde78b29aedb7db1e96602fd4d53d625 Author: Mark Cogan <marq@google.com> Date: Fri Feb 09 19:27:11 2018 [iOS] Improve fix for NTP flicker during first run. The existing fix for the NTP flickering in when the FRE view is shown doesn't work when the BVC itself is presented. This CL improves that fix by not depending on the BVC's view having a window when -presentViewController:animated: is called. Bug: 798042 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ddb8a1867ff84d15b912e607dfce3f180d011e9 Reviewed-on: https://chromium-review.googlesource.com/895685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#533673}(cherry picked from commit 38a8848db004ce5b8c7f2269e1e2e6abca5f2db9) Reviewed-on: https://chromium-review.googlesource.com/912129 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#409} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/44da87accde78b29aedb7db1e96602fd4d53d625/ios/chrome/browser/ui/browser_view_controller.mm
,
Feb 14 2018
Verified in: App Version: 65.0.3325.70 beta Devices: iPad Mini, iPhone 6S Plus, iPhone 8 Plus iOS Versions: 10.3.3, 11.2.5 NTP flickering issue during First Run has been fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by olivierrobin@chromium.org
, Dec 29 2017Labels: M-65 ReleaseBlock-Stable
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)