New issue
Advanced search Search tips

Issue 798035 link

Starred by 2 users
Status: Duplicate
Merged: issue 788570
Owner:
hs1217....@samsung.com
Closed: Dec 2017
Cc:
shend@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-typed-om] CSSStyleValue.parse should be return appropriate CSSStyleValue subclasses

Project Member Reported by hs1217....@samsung.com, Dec 29 2017 
CSSStyleValue.parse should be return CSSPositionValue when properties which is related with position passed as first parameter.

if it will be implement, below tests will be pass.
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/typedcssom/stylevalue-serialization/cssPositionValue.html?q=cssPositionValue.html&sq=package:chromium&dr

Comment 1 by hs1217....@samsung.com, Dec 29 2017

Owner: hs1217....@samsung.com
Status: Started (was: Available)
@shend
i will make patch in order to return CSSPositionValue.

Comment 2 by ericwilligers@chromium.org, Dec 29 2017 

BTW, 'CSSPositionValue from DOMString modified by "x" setter serializes correctly' test is incorrect.
It should have 1px for y, not 1%:  assert_equals(result.toString(), '-3.14% 1px');

Comment 3 by hs1217....@samsung.com, Dec 29 2017 

@ericwilligers
right, when i saw that tests, i found it too. i will fix it together. :)

Comment 4 by shend@chromium.org, Dec 29 2017 

Oops yeah sorry, copy and paste errors :( You never know if your tests are right until you have an implementation to test it with :P

Comment 5 by shend@chromium.org, Dec 29 2017 

Hey sorry, I just took at this now. I'm actually implementing this right now in [1], as part of  crbug.com/788570 .

[1] https://chromium-review.googlesource.com/c/chromium/src/+/846579 (WIP).

Comment 6 by hs1217....@samsung.com, Dec 29 2017

Mergedinto: 788570
Status: Duplicate (was: Started)
@shend
i am fine. i will close this issue. thanks.
►

Sign in to add a comment