WebAPKs currently do not currently use a WebAPK-specific renderer. We have no plans to do so in the foreseeable future. We might as well rip out the functionality
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/162143b1d7f0e34f7b8040b249d28bf8b946648a commit 162143b1d7f0e34f7b8040b249d28bf8b946648a Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Thu Jan 18 06:27:42 2018 [Android WebAPK] Delete WebApkSandboxedProcess part 1 We are not using WebApkSandboxedProcess and have no plans of using it in the future. Delete it. BUG= 797999 Change-Id: Iad640ed6c5d341aac52c5b0d62fe725c771db3ff Reviewed-on: https://chromium-review.googlesource.com/845822 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530073} [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/base/BUILD.gn [rename] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/base/android/child_process_service.cc [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/base/android/java/src/org/chromium/base/process_launcher/ChildProcessService.java [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/base/android/java/src/org/chromium/base/process_launcher/ChildProcessServiceImpl.java [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/chrome/android/java/src/org/chromium/chrome/browser/WebApkChildProcessServiceImpl.java [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/java_sources.gni [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/webapk/shell_apk/AndroidManifest.xml [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/android/webapk/shell_apk/shell_apk_version.gni [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService0.java [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService1.java [delete] https://crrev.com/17ee3de54388382d020e6e7420ddb945ec6e23aa/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService2.java [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/browser/BUILD.gn [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/chrome/browser/android/webapk/chrome_webapk_host.cc [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/content/app/android/content_child_process_service_delegate.cc [modify] https://crrev.com/162143b1d7f0e34f7b8040b249d28bf8b946648a/content/public/android/java/src/org/chromium/content/app/ContentChildProcessServiceDelegate.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8000b47bd186a17ad51a969bda0a865c79e1f54d commit 8000b47bd186a17ad51a969bda0a865c79e1f54d Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Wed Jan 24 23:23:49 2018 Remove ability to register multiple ChildProcessCreationParams objects part 1 BUG= 797999 Change-Id: I7545418680181af1c47fb5cd6578299be5f3deba Reviewed-on: https://chromium-review.googlesource.com/872572 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531740} [modify] https://crrev.com/8000b47bd186a17ad51a969bda0a865c79e1f54d/content/browser/child_process_launcher_helper_android.cc [modify] https://crrev.com/8000b47bd186a17ad51a969bda0a865c79e1f54d/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java [modify] https://crrev.com/8000b47bd186a17ad51a969bda0a865c79e1f54d/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1 commit f7053a84a3da4f53c22cf6ba89a85398c5fe36f1 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Jan 29 23:22:11 2018 Remove ability to register multiple ChildProcessCreationParams objects part 2 This CL: - Removes ChildProcessLauncherHelper#mCreationParams - Moves public static ChildProcessCreationParams accessors from ChildProcessLauncherHelper.java to ChildProcessCreationParams.java - Changes type of ChildProcessLauncherHelper#sSandboxedChildConnectionAllocatorMap from Map<String, ChildConnectionAllocator> to ChildConnectionAllocator (The map is no longer needed because WebAPKs no longer have special ChildProcessCreationParams) - As there is now just one sandboxed ChildConnectionAllocator we now no longer free the allocator when the last connection is freed. This matches what we do for ChildProcessLauncherHelper#sPrivilegedChildConnectionAllocator Deleted tests: - Tested creating multiple allocators - testAllocatorForPackage() - testCustomCreationParamDoesNotReuseWarmupConnection() introduced in https://codereview.chromium.org/2705133002 - Tested that ChildConnectionAllocator is freed when last sandboxed connection was freed - testSandboxedAllocatorFreed() introduced in https://chromium-review.googlesource.com/c/chromium/src/+/513587 - testSandboxedAllocatorFreedWith2Connections() introduced in https://chromium-review.googlesource.com/c/chromium/src/+/588380 BUG= 797999 Change-Id: I2147ae24d99a7e8b2d93bb7f5a4a2b5ae37172f8 Reviewed-on: https://chromium-review.googlesource.com/884621 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532653} [modify] https://crrev.com/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java [modify] https://crrev.com/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java [modify] https://crrev.com/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java [modify] https://crrev.com/f7053a84a3da4f53c22cf6ba89a85398c5fe36f1/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b719468b74f259f5dd9e29e958534af9646bd2c8 commit b719468b74f259f5dd9e29e958534af9646bd2c8 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Tue Jan 30 05:00:12 2018 Remove ability to register multiple ChildProcessCreationParams objects part 3 This CL changes the custom-package-name specified in ChildProcessCreationParams to apply to both sandboxed and unsandboxed services. Perviously when a user launched a WebAPK: - Renderers would use a non-Chrome sandboxed process defined in the WebAPK APK - The GPU process would run in a Chrome process WebAPKs no longer use a non-Chrome process for renderers. This leaves us with two cases: Case #1 - Chrome - Renderer runs in Chrome-process (Package name provided by application context) - GPU process runs in Chrome-process (Package name provided by application context) Case #2 - Android Webview - Renderer runs in Chrome-process (Package name different than application context) - Does not use GPU process or other non-sandboxed processes Bug= 797999 Change-Id: I050e9e16a6a9a17c99d46c33e0ce190d17e66d98 Reviewed-on: https://chromium-review.googlesource.com/885781 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532762} [modify] https://crrev.com/b719468b74f259f5dd9e29e958534af9646bd2c8/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java [modify] https://crrev.com/b719468b74f259f5dd9e29e958534af9646bd2c8/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/679a628f029450bea9284be3dd14b325fd13c150 commit 679a628f029450bea9284be3dd14b325fd13c150 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Thu Feb 08 00:08:01 2018 Remove ability to register multiple ChildProcessCreationParams objects part 4 This CL removes the org.chromium.content.browser.SANDBOXED_SERVICES_NAME <meta-data> key. The <meta-data> key used to be necessary because we needed to lookup the name of the sandboxed service in the WebAPK. Now that we are removing this functionality, the <meta-data> key is no longer needed. Bug= 797999 R=slan@, jcivelli@, boliu@, yfriedman@ TBR=tedchoc@ for //components/test/android Change-Id: Ibcc524d4952da7443214aeec6d308f209732d3ff Reviewed-on: https://chromium-review.googlesource.com/887383 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Stephen Lanham <slan@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#535202} [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/android_webview/apk/java/AndroidManifest.xml [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/android_webview/test/shell/AndroidManifest.xml [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/base/android/java/src/org/chromium/base/process_launcher/ChildConnectionAllocator.java [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/chromecast/browser/android/apk/AndroidManifest.xml.jinja2 [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/content/shell/android/linker_test_apk/AndroidManifest.xml.jinja2 [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/content/shell/android/shell_apk/AndroidManifest.xml.jinja2 [modify] https://crrev.com/679a628f029450bea9284be3dd14b325fd13c150/testing/android/native_test/java/AndroidManifest.xml.jinja2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ba124d383a092cf046080073f78a9839548cc21 commit 8ba124d383a092cf046080073f78a9839548cc21 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Fri Feb 09 17:35:36 2018 [Android] Rename ChildProcessCreationParams#getDefault() to #get() This CL renames ChildProcessCreationParams#getDefault() to get() ChildProcessCreationParams#registerDefault() to set() get() and set() are more intuitive now that there are just one ChildProcessCreationParams Bug= 797999 R=boliu@ TBR=yfriedman@ (For trivial refactor in MonochromeApplication.java) Change-Id: I7b47ced2f0116f9baa1180189ce81cef136f8e78 Reviewed-on: https://chromium-review.googlesource.com/887402 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#535743} [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/chrome/android/java/src/org/chromium/chrome/browser/MonochromeApplication.java [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherHelperTest.java [modify] https://crrev.com/8ba124d383a092cf046080073f78a9839548cc21/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java
Comment 1 by pkotw...@chromium.org
, Dec 28 2017Labels: OS-Android