New issue
Advanced search Search tips

Issue 797991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

clang package.py script on windows produces many warnings in compiler-rt, needs newer cmake

Project Member Reported by r...@chromium.org, Dec 28 2017

Issue description

This successful build log shows the issue:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win_upload_clang/280

[1978/3876] Building CXX object projects\compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommon.x86_64.dir\sanitizer_errno.cc.obj
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-builtin' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-exceptions' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fomit-frame-pointer' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-funwind-tables' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-stack-protector' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fvisibility=hidden' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-lto' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-rtti' [-Wunknown-argument]
[1979/3876] Building CXX object lib\WindowsManifest\CMakeFiles\LLVMWindowsManifest.dir\WindowsManifestMerger.cpp.obj
[1980/3876] Building CXX object lib\Target\XCore\CMakeFiles\LLVMXCoreCodeGen.dir\XCoreFrameLowering.cpp.obj
[1981/3876] Building CXX object projects\compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommon.x86_64.dir\sanitizer_deadlock_detector2.cc.obj
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-builtin' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-exceptions' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fomit-frame-pointer' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-funwind-tables' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-stack-protector' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fvisibility=hidden' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-lto' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-rtti' [-Wunknown-argument]


That's because the C++ flag test succeeds:
-- Performing Test COMPILER_RT_HAS_STD_CXX11_FLAG
-- Performing Test COMPILER_RT_HAS_STD_CXX11_FLAG - Success
-- Performing Test COMPILER_RT_HAS_FTLS_MODEL_INITIAL_EXEC
-- Performing Test COMPILER_RT_HAS_FTLS_MODEL_INITIAL_EXEC - Success

This looks like an old cmake+clang-cl bug that I filed:
https://cmake.org/Bug/view.php?id=16038

I think we can just upgrade cmake to something more recent to pick up the fix.
 
Cc: thakis@chromium.org
Still happens, not that we care that much about our package.py log size:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win_upload_clang/370

[433/4123] Building CXX object projects\compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommon.x86_64.dir\sanitizer_deadlock_detector2.cc.obj
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-std=c++11' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-exceptions' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fomit-frame-pointer' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-funwind-tables' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-stack-protector' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fvisibility=hidden' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-lto' [-Wunknown-argument]
clang-cl.exe: warning: unknown argument ignored in clang-cl: '-fno-rtti' [-Wunknown-argument
Nice, I didn't know a cmake update fixes this! I'm getting this all the time locally as well :-D
Owner: h...@chromium.org
Status: Started (was: Assigned)
I started looking at this. The upstream cmake package for Linux won't run with the libstdc++ version we're using in update.py, so I'm trying a patch to just use the default libstdc++ here: https://chromium-review.googlesource.com/c/chromium/src/+/1183915

If that sticks, I have a patch to move to the latest cmake version.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0546b3534632dcc649027d016e70164b00a86aaa

commit 0546b3534632dcc649027d016e70164b00a86aaa
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Aug 24 19:51:07 2018

Clang: stop building with GCC/libstdc++ from Ubuntu Precise

Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang
that would work on Precise or later. These days, all bots and developers are on
Trusty or later, so this should no longer be necessary.

Besides simplifying things, this allows us to easier move to using the
latest CMake when building Clang, because it was built with a newer
libstdc++ than the Precise one.

Bug:  797991 
Change-Id: I528825389241f60ccc96167015370cd5e285725d
Reviewed-on: https://chromium-review.googlesource.com/1188679
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585953}
[modify] https://crrev.com/0546b3534632dcc649027d016e70164b00a86aaa/tools/clang/scripts/update.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/814930c5133aacaf7310960087927374a8e514ea

commit 814930c5133aacaf7310960087927374a8e514ea
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Aug 24 20:36:32 2018

Clang update script: use a newer CMake

This depends on https://chromium-review.googlesource.com/c/chromium/src/+/1188679

Bug:  797991 
Change-Id: I81f648d269152eafbb6208d0c831e2d14511fc0c
Reviewed-on: https://chromium-review.googlesource.com/1187160
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585976}
[modify] https://crrev.com/814930c5133aacaf7310960087927374a8e514ea/tools/clang/scripts/update.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/536bb7d3cf643f606bc91678a1fcaf4077f76f99

commit 536bb7d3cf643f606bc91678a1fcaf4077f76f99
Author: Reid Kleckner <rnk@google.com>
Date: Fri Aug 24 23:32:37 2018

Fix path to CMake bin directory in update.py

There is no extra 'cmake' path component after bin on Linux.
Hopefully this will resurrect the Linux Clang ToT bots after
https://crrev.com/585976.

TBR=hans@chromium.org
NOTRY=True

Bug:  797991 
Change-Id: I7e1e38e824c8986303a9ec1972bb5f57a2cd9bea
Reviewed-on: https://chromium-review.googlesource.com/1189034
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586051}
[modify] https://crrev.com/536bb7d3cf643f606bc91678a1fcaf4077f76f99/tools/clang/scripts/update.py

Status: Fixed (was: Started)

Sign in to add a comment