New issue
Advanced search Search tips

Issue 797987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 797979
issue 797980



Sign in to add a comment

Report data savings from page load capping

Project Member Reported by ryansturm@chromium.org, Dec 28 2017

Issue description

Page load capping should report data savings to the data saver UI. This will likely be a heuristic that looks at pages of size X or higher. The median of these pages will generally be considered the original content length unless the page has already used more data than that.
 
Blockedon: 797980
Refreshed during triage.
Refreshed during triage.
Status: Started (was: Assigned)
Blockedon: 797979

Comment 6 by bengr@chromium.org, Jun 5 2018

Labels: -M-66 M-69
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1366dbe6a4c569a77c65dce5af4752d045dda219

commit 1366dbe6a4c569a77c65dce5af4752d045dda219
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Jun 07 22:46:41 2018

Adding data savings to the page load capping feature

Data savings are considered to be the size of the network usage on the
page compared to an estimate. If the user saved data, we report that
savings, if the user went over the estimate, we report 0 savings.

Bug:  797987 
Change-Id: I5afb3c4409331c1d86c23cf80263abfaef9abdd5
Reviewed-on: https://chromium-review.googlesource.com/1091116
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565447}
[modify] https://crrev.com/1366dbe6a4c569a77c65dce5af4752d045dda219/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/1366dbe6a4c569a77c65dce5af4752d045dda219/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h
[modify] https://crrev.com/1366dbe6a4c569a77c65dce5af4752d045dda219/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment