New issue
Advanced search Search tips

Issue 797981 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Jun 2018
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 797979
issue 797980
issue 852593


Sign in to add a comment

Prevent over-triggering of the page load capping infobar

Project Member Reported by ryansturm@chromium.org, Dec 28 2017 
When a user continually does not engage with the page load capping infobar on a domain or in general, the user should not be shown the infobar as often (or at all in some cases). This behavior is similar to existing previews logic WRT preventing previews from being shown.

Comment 1 by ryansturm@chromium.org, Dec 28 2017

Blockedon: 797980

Comment 2 by dougarnett@chromium.org, Feb 13 2018 

Refreshed during triage.

Comment 3 by sclit...@chromium.org, Apr 11 2018 

Refreshed during triage.

Comment 4 by ryansturm@chromium.org, May 22 2018

Blockedon: 797979

Comment 5 by bengr@chromium.org, Jun 5 2018

Labels: -M-66 M-69

Comment 6 by ryansturm@chromium.org, Jun 13 2018

Blockedon: 852593

Comment 7 by ryansturm@chromium.org, Jun 14 2018

Blocking: 709493

Comment 8 by ryansturm@chromium.org, Jun 14 2018

Blocking: -709493

Comment 9 by ryansturm@chromium.org, Jun 22 2018 

This should be able to use the blacklist component once one more CL lands.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd53b6f54660635abec092b800714e5d6a131186

commit cd53b6f54660635abec092b800714e5d6a131186
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Jun 28 19:18:43 2018

Adding a keyed service for page load capping

This keyed service owns a blacklist and the blacklist is used in the
triggering pipeline to prevent over triggering of the feature.

Bug:  797981 
Change-Id: Ib6afd870b48032363af9235184d1df24c51a195e
Reviewed-on: https://chromium-review.googlesource.com/1114331
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571219}
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/BUILD.gn
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_blacklist.cc
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_blacklist.h
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_blacklist_unittest.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_service.cc
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_service.h
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_service_factory.cc
[add] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_service_factory.h
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/common/chrome_constants.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/common/chrome_constants.h
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/chrome/test/BUILD.gn
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/components/blacklist/opt_out_blacklist/opt_out_blacklist.cc
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/components/blacklist/opt_out_blacklist/opt_out_blacklist_data.h
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/cd53b6f54660635abec092b800714e5d6a131186/tools/metrics/histograms/histograms.xml
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1090bf6cd97ecf24153281b3f33618d62543ac34

commit 1090bf6cd97ecf24153281b3f33618d62543ac34
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Jun 28 23:47:32 2018

Clearing page load capping blacklist when user clears history

This call clears persisted state that is tied to navigation history.

Bug:  797981 
Change-Id: Ie0e2224f673b07ef6edc80e30f0cbb518dea0029
Reviewed-on: https://chromium-review.googlesource.com/1119157
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571329}
[modify] https://crrev.com/1090bf6cd97ecf24153281b3f33618d62543ac34/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/1090bf6cd97ecf24153281b3f33618d62543ac34/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc

Comment 12 by ryansturm@chromium.org, Jun 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment