New issue
Advanced search Search tips

Issue 797975 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 797976



Sign in to add a comment

Add a page load capping feature

Project Member Reported by ryansturm@chromium.org, Dec 28 2017

Issue description

Page load capping should be behind a base::Feature. This will control triggering and tracking in the feature.
 
Blocking: 797976
Labels: -Pri-3 M-66 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91264c3bd8626e2cfb9e577788dd67e1ae5c9676

commit 91264c3bd8626e2cfb9e577788dd67e1ae5c9676
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Dec 28 23:02:55 2017

Adding a feature for page load capping

This CL adds a feature to detect heavy pages as well as a
PageLoadObserver that is created only when the feature is enabled. This
observer only checks that its methods are called on the correct
sequence.

Bug:  797975 
Change-Id: I2b5dd655650ad99a661ce52f6b3179145a0dbe88
Reviewed-on: https://chromium-review.googlesource.com/846027
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526334}
[modify] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/BUILD.gn
[modify] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
[modify] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
[add] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/page_load_capping/chrome_page_load_capping_features.cc
[add] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/page_load_capping/chrome_page_load_capping_features.h
[add] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/page_load_capping/page_load_observer.cc
[add] https://crrev.com/91264c3bd8626e2cfb9e577788dd67e1ae5c9676/chrome/browser/data_use_measurement/page_load_capping/page_load_observer.h

Status: Fixed (was: Assigned)

Sign in to add a comment