Eliminate stale references to token service in chrome_cryptauth_service.* |
|||||||
Issue descriptionChromeCryptAuthService observes O2TS and SigninManager. It checks whether user is authenticated to determine whether to delay startup, observing the SigninManager for signin if user is not signed in. It checks whether a refresh token is available with PO2TS, observing PO2TS if refresh token is not available. There is also a unittest. This should be easily convertible to interact with IdentityManager. We might need to extend the IdentityManager observer API.
,
Dec 29 2017
,
Feb 6 2018
,
Jun 26 2018
,
Sep 12
The conversion is complete but there are stale references/includes lingering that should be removed.
,
Oct 1
I believe the only includes that can be removed are these ones: #include "components/signin/core/browser/profile_oauth2_token_service.h" #include "components/signin/core/browser/signin_manager.h" I'll prepare a CL
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/824d44edccc8d812c418f0aaafdf74be1d701fd9 commit 824d44edccc8d812c418f0aaafdf74be1d701fd9 Author: Mario Sanchez Prada <mario@igalia.com> Date: Tue Oct 09 09:09:40 2018 Eliminate stale references to token service and the SigninManager There are two includes that are no longer used and can be safely removed: profile_oauth2_token_service.h and signin_manager.h. Bug: 797949 Change-Id: I8a2faebd291dc9ae9d9cabe18241c2556ed55132 Reviewed-on: https://chromium-review.googlesource.com/c/1255522 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#597847} [modify] https://crrev.com/824d44edccc8d812c418f0aaafdf74be1d701fd9/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
,
Oct 9
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dtapu...@chromium.org
, Dec 28 2017