New issue
Advanced search Search tips

Issue 797948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert first_run code to talk to Identity Service client lib

Project Member Reported by blundell@chromium.org, Dec 28 2017

Issue description

Across several platforms, first_run code gets the info of the user's authenticated account:

//chrome/browser/chromeos/first_run.cc gets the user’s authenticated account info to find out if they’re on a hosted domain.
//chrome/browser/first_run.cc gets the user’s authenticated account info to find out if auth is in progress.
//ios/chrome/browser/ui/first_run/first_run_util.mm gets the user’s authenticated account info to collect metrics.

This should all be converted to interact with IdentityManager.

 
Components: Internals>Services>Identity
Blocking: 796544
Status: Available (was: Untriaged)
Labels: -Pri-3 Proj-Servicification Pri-2
Owner: jochen@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38bb1df1d0e6d24652947d773cf78761036b8ba

commit b38bb1df1d0e6d24652947d773cf78761036b8ba
Author: Jochen Eisinger <jochen@chromium.org>
Date: Wed Aug 08 09:39:05 2018

Use IdentityManager to get profile signin state during first run

BUG= 797948 
R=msarda@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibf031e86d4e7a9385e01ac872566f63bb4564f9a
Reviewed-on: https://chromium-review.googlesource.com/1163668
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581507}
[modify] https://crrev.com/b38bb1df1d0e6d24652947d773cf78761036b8ba/chrome/browser/chromeos/first_run/first_run.cc
[modify] https://crrev.com/b38bb1df1d0e6d24652947d773cf78761036b8ba/chrome/browser/first_run/first_run.cc
[modify] https://crrev.com/b38bb1df1d0e6d24652947d773cf78761036b8ba/ios/chrome/browser/ui/first_run/BUILD.gn
[modify] https://crrev.com/b38bb1df1d0e6d24652947d773cf78761036b8ba/ios/chrome/browser/ui/first_run/first_run_util.mm

Status: Fixed (was: Assigned)

Sign in to add a comment