Updating this bug to reflect the current state of the world.

Note that converting the production code away from GaiaCookieManagerService is necessary to convert the unittest away from ProfileOAuth2TokenService: the unittest constructs a FakePO2TS to pass in to the FakeGCMS that it then passes to the production code.

See the blocking bugs. Note that we should be able to do the conversion away from SigninManager even before the blocking bugs are fixed.

Working on this

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8853032ec0edd9f4656c7abaeda4c504934c6119

commit 8853032ec0edd9f4656c7abaeda4c504934c6119
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Thu Jan 10 10:48:59 2019

Replace SigninManager by IdentityManager in AccountConsistencyService

It was using the SigninManager API to observe primary account sign-in
status changes and also to verify whether a primary account was set or
not. The IdentityManager API is a good replacement for those use cases.

Note that the class is still using GaiaCookieManagerService but in
order to move that code away from that dependency the unit test needs
to be converted away from any usage of ProfileOAuth2TokenService. That
will be done in a follow-up patch.

Bug: 797931
Change-Id: I0820d0c229dbba3ec2c2df1c9432f6275571db45
Reviewed-on: https://chromium-review.googlesource.com/c/1394525
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621536}
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/components/signin/ios/DEPS
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/components/signin/ios/browser/BUILD.gn
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/components/signin/ios/browser/account_consistency_service.h
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/components/signin/ios/browser/account_consistency_service_unittest.mm
[modify] https://crrev.com/8853032ec0edd9f4656c7abaeda4c504934c6119/ios/chrome/browser/signin/account_consistency_service_factory.mm

Re-opening this as the unittest still needs conversion. Sergio, are you actively planning on following up here, or should we mark it available?

Oh I closed it by mistake, I'm still actively working on it BTW.

(this one is actually P1 as the GCMS conversion is needed to convert SigninManager and PO2TS)