New issue
Advanced search Search tips

Issue 797929 link

Starred by 1 user
Status: Fixed
Owner:
chcunningham@chromium.org
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert SearchTabHelper to talk to Identity Service client lib

Project Member Reported by blundell@chromium.org, Dec 28 2017 
SearchTabHelper just gets the information of the primary account; it can do so via IdentityManager.

Comment 1 by dtapu...@chromium.org, Dec 28 2017

Components: Internals>Services>Identity

Comment 2 by blundell@chromium.org, Dec 29 2017

Blocking: 796544
Status: Available (was: Untriaged)

Comment 3 by blundell@chromium.org, Jul 9

Owner: chcunningham@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6aa64dbb265a2fcdf75069a1a6269e4a00c0da

commit da6aa64dbb265a2fcdf75069a1a6269e4a00c0da
Author: chcunningham <chcunningham@chromium.org>
Date: Fri Jul 13 13:54:21 2018

Convert SearchTabHelper to use IdentityManager

IdentityManager is the recommended API to access the
Google account used by the user and SigninManager is
deprecated.

Bug:  797929 
Change-Id: Ia182b65b4bd764821bd7cb46524b6400b5c35828
Reviewed-on: https://chromium-review.googlesource.com/1128809
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574902}
[modify] https://crrev.com/da6aa64dbb265a2fcdf75069a1a6269e4a00c0da/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/da6aa64dbb265a2fcdf75069a1a6269e4a00c0da/chrome/browser/ui/search/search_tab_helper_unittest.cc

Comment 5 by chcunningham@chromium.org, Jul 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment