New issue
Advanced search Search tips

Issue 797928 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 890800
Owner: ----
Closed: Dec 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert chrome_pages.cc and testing code in //chrome/browser/ui to talk to Identity Service client lib

Project Member Reported by blundell@chromium.org, Dec 28 2017

Issue description

chrome_pages.cc DCHECKS(SigninManager::IsSigninAllowed()) when showing a browser signin window. SigninManager::IsSigninAllowed() just checks a pref. This method is used in SigninManager itself as well. We'll do this conversion after determining the picture for prefs shared between the Identity Service impl and clients.

chrome_pages.cc also calls SigninManager::IsAuthenticated() to determine whether to show settings or a signin page. This can just be converted to talk to the IdentityManager.

There are also tests that have dependencies that need to be converted.

 
Components: Internals>Services>Identity
Blocking: 796544
Status: Available (was: Untriaged)
Mergedinto: 890800
Status: Duplicate (was: Available)

Sign in to add a comment