Convert signin_global_error to talk to Identity Service client lib |
||||
Issue descriptionThis just involves converting access to user's primary account to be via IdentityManager rather than SigninManager, plus some associated testing changes.
,
Dec 29 2017
,
Dec 17
This has been partially fixed now by crbug.com/890792 , only the bits in signin_global_error_unittest.cc remain to be fixed here.
,
Dec 17
Taking this one, tentative CL in here: https://chromium-review.googlesource.com/c/chromium/src/+/1380018
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3eb5f8a1acc9798c923b9a56343690feea42674 commit f3eb5f8a1acc9798c923b9a56343690feea42674 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Dec 19 15:32:13 2018 Convert signin_global_error to talk to Identity Service Replace usage of SigninManager and ProfileOAuth2TokenService's APIs with IdentityTestEnvironment[ProfileAdaptor] and IdentityManager. Bug: 797927 Change-Id: I989d9160484f104c5e4bf8f8f24d4523c7963f2a Reviewed-on: https://chromium-review.googlesource.com/c/1380018 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#617839} [modify] https://crrev.com/f3eb5f8a1acc9798c923b9a56343690feea42674/chrome/browser/signin/signin_global_error_unittest.cc
,
Dec 19
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dtapu...@chromium.org
, Dec 28 2017