New issue
Advanced search Search tips

Issue 797900 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: resolver->GetFrame() in CredentialsContainer.cpp

Project Member Reported by ClusterFuzz, Dec 28 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4583102524686336

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  resolver->GetFrame() in CredentialsContainer.cpp
  blink::CheckSecurityRequirementsBeforeRequest
  blink::CredentialsContainer::get
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=526172:526174

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4583102524686336

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 28 2017

Components: Blink>JavaScript Blink>SecurityFeature>CredentialManagement
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by mkwst@chromium.org, Dec 28 2017

Owner: engedy@chromium.org
Status: Assigned (was: Untriaged)
I would not be shocked if this had something to do with your recent refactoring, engedy@. :)

Comment 3 by engedy@chromium.org, Dec 28 2017

Yeah, but the fuzzer input seemingly never calls CM API methods. So I'm not sure how this is possible. Any caveats I may be missing?
Cc: kkaluri@chromium.org engedy@chromium.org
 Issue 797735  has been merged into this issue.
Labels: OS-Android OS-Windows
Status: Started (was: Assigned)
This can be reproduced locally, investigating...
 Issue 797132  has been merged into this issue.
 Issue 797190  has been merged into this issue.
 Issue 797459  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17beb99df0260b16b2e08036a49219dc9fcf9f05

commit 17beb99df0260b16b2e08036a49219dc9fcf9f05
Author: Balazs Engedy <engedy@chromium.org>
Date: Thu Jan 04 16:36:07 2018

Ignore calls to CredentialsContainer whose responsible document was detached.

The `window.opener` might be storing a reference to `window.navigator.credentials`,
and call methods on it after the opened `window` is navigated away and hence its
relevant settings object's responsible document is already destroyed.

We should ignore calls to navigator.credentials methods in this case and not crash.

Bug:  797900 
Change-Id: I6507cb30b8d9d967a1d218135388fc833d215c69
Reviewed-on: https://chromium-review.googlesource.com/848914
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527004}
[add] https://crrev.com/17beb99df0260b16b2e08036a49219dc9fcf9f05/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-detached.html
[add] https://crrev.com/17beb99df0260b16b2e08036a49219dc9fcf9f05/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/notify-opener-on-load.html
[modify] https://crrev.com/17beb99df0260b16b2e08036a49219dc9fcf9f05/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Status: Fixed (was: Started)
Project Member

Comment 12 by ClusterFuzz, Jan 5 2018

ClusterFuzz has detected this issue as fixed in range 526988:527007.

Detailed report: https://clusterfuzz.com/testcase?key=4583102524686336

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_cfi_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  resolver->GetFrame() in CredentialsContainer.cpp
  blink::CheckSecurityRequirementsBeforeRequest
  blink::CredentialsContainer::get
  
Sanitizer: cfi (CFI)

Regressed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=526172:526174
Fixed: https://clusterfuzz.com/revisions?job=linux_cfi_chrome&range=526988:527007

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4583102524686336

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jan 5 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4583102524686336 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/148c08d6840000

Sign in to add a comment