New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 797891 link

Starred by 4 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Jan 2018
Cc:
ajha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blink of enabled 'CONNECT' button and enabled toggle button of 'Allow other users of this device to use this network' is seen after clicking on required Wi-Fi network in OOBE Screen

Project Member Reported by mmanchala@chromium.org, Dec 28 2017 
Chrome Version:  65.0.3299.0/10256.0.0 Wolf,Paine and Cyan
OS: Chrome

What steps will reproduce the problem?
(1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
(2)Now select required Wi-Fi network -> Observe blink of enabled 'CONNECT' button and enabled toggle button of 'Allow other users of this device to use this network' in 'Join Wi-Fi network' overlay  
(Please refer video and Screenshot)

Expected: No such blink of enabled 'CONNECT' button and enabled toggle button of 'Allow other users of this device to use this network'  should be seen  in 'Join Wi-Fi network' overlay  
Actual: Instead blink of enabled 'CONNECT' button and enabled toggle button of 'Allow other users of this device to use this network' is seen 

This is Regression Issue as same is working fine in 65.0.3294.0/10216.0.0 dev-channel Paine

@stevenjb : Please confirm the Issue
Actual_EnabledConnectButtonAndToggleButton.mp4
8.4 MB View Download
Actual_EnabledConnectButtonAndToggleButton.jpg
164 KB View Download
Expected_DisabledConnectButton.mp4
7.0 MB View Download

Comment 1 by steve...@chromium.org, Jan 18 2018

Status: Started (was: Assigned)
Will be fixed with  issue 795718
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02c820b848e1ea34d82084518fe1ccce51c290

commit cb02c820b848e1ea34d82084518fe1ccce51c290
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 19 18:15:02 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530564}
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb02c820b848e1ea34d82084518fe1ccce51c290

commit cb02c820b848e1ea34d82084518fe1ccce51c290
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 19 18:15:02 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530564}
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.cc
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/chromeos/network/network_state.h
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/cb02c820b848e1ea34d82084518fe1ccce51c290/ui/webui/resources/cr_components/chromeos/network/network_config_input.html

Comment 4 by steve...@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
Project Member

Comment 5 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Jan 19 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Comment 6 by steve...@chromium.org, Jan 23 2018

Labels: -Merge-TBD Merge-Request-65
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 23 2018

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c9b21327ccd96f86a50456e9e72ce43aaee244

commit 14c9b21327ccd96f86a50456e9e72ce43aaee244
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 23 22:54:20 2018

Fix network config focus issues

* Correctly focuses SSID or passphrase field
* Correctly enables 'connect' button as soon as valid input is typed
* Defaults 'Connect' button to disabled to avoid initial blink
* Sizes the dialog correctly when just a passphrase is required
* Uses the new dialogs correctly from the 'Network not available'
  screen in login/oobe.

TBR=stevenjb@chromium.org

(cherry picked from commit cb02c820b848e1ea34d82084518fe1ccce51c290)

Bug:  795718 , 797891 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie81d3c16db56d8a0c020da3e001f9118b638974b
Reviewed-on: https://chromium-review.googlesource.com/869116
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530564}
Reviewed-on: https://chromium-review.googlesource.com/882185
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#41}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chrome/test/data/webui/cr_components/network_config_test.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_state.cc
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/chromeos/network/network_state.h
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/ui/webui/resources/cr_components/chromeos/network/network_config.js
[modify] https://crrev.com/14c9b21327ccd96f86a50456e9e72ce43aaee244/ui/webui/resources/cr_components/chromeos/network/network_config_input.html
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by steve...@chromium.org, Jan 24 2018

Labels: -Merge-Approved-65
►

Sign in to add a comment