New issue
Advanced search Search tips

Issue 797886 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 796544



Sign in to add a comment

Convert metrics to use Identity Service client library

Project Member Reported by blundell@chromium.org, Dec 28 2017

Issue description

This should just be a matter of having ukm_browsertest.cc get the primary account info from the IdentityManager rather than SigninManager.
 
Components: Internals>Services>Identity
Blocking: 796544
Status: Available (was: Untriaged)
Labels: -Pri-3 Proj-Servicification Proj-Servicification-VendorBug Pri-1
Owner: ma...@igalia.com
Status: Started (was: Available)
Taking this one. CL here:
https://chromium-review.googlesource.com/c/chromium/src/+/1380091
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09107ed657a687beb8e239ba5d0a648cc15bdbe6

commit 09107ed657a687beb8e239ba5d0a648cc15bdbe6
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Tue Dec 18 15:04:35 2018

Convert metrics to use Identity Service client library

At this point, this means converting the usage of SigninManagerBase API
in ukm_browsertest.cc, depend on the right factory (IdentityManagerFactory)
from DesktopProfileSessionDurationsServiceFactory and remove stale includes.

Bug:  797886 
Change-Id: Ib5861095f0265de71aa1e58cb37895991420dc85
Reviewed-on: https://chromium-review.googlesource.com/c/1380091
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#617493}
[modify] https://crrev.com/09107ed657a687beb8e239ba5d0a648cc15bdbe6/chrome/browser/metrics/ukm_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment