This code looks like it might be suitable for culling based on the comment here: https://cs.chromium.org/chromium/src/components/signin/core/browser/refresh_token_annotation_request.h?q=refresh_token_anno&sq=package:chromium&l=20. If the code stays, it needs to be converted to use the Identity Service client lib rather than signin internal code. To do this conversion, we'll need to have the client API for fetching an access token for a given account ID in place. Pavel, do you think that we can just remove this code?
Yes, RefreshTokenAnnotationRequest and corresponding call sites should be removed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30843068b11022756024311347dcbd0490e2ecf6 commit 30843068b11022756024311347dcbd0490e2ecf6 Author: Colin Blundell <blundell@chromium.org> Date: Fri Jan 12 15:44:34 2018 Remove RefreshTokenAnnotationRequest This code is no longer needed (see crbug.com/797883 ). Bug: 797883 Change-Id: I5b1d0b4b1568f24d8fabbf0d7f461c876c2f31b1 Reviewed-on: https://chromium-review.googlesource.com/857459 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#528954} [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/BUILD.gn [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/account_fetcher_service.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/account_fetcher_service.h [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/fake_account_fetcher_service.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/fake_account_fetcher_service.h [delete] https://crrev.com/3a6f96ea8c6aa8502b04006948a7bc3709c33981/components/signin/core/browser/refresh_token_annotation_request.cc [delete] https://crrev.com/3a6f96ea8c6aa8502b04006948a7bc3709c33981/components/signin/core/browser/refresh_token_annotation_request.h [delete] https://crrev.com/3a6f96ea8c6aa8502b04006948a7bc3709c33981/components/signin/core/browser/refresh_token_annotation_request_unittest.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/signin_manager_base.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/signin_pref_names.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/signin_pref_names.h [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/signin_switches.cc [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/components/signin/core/browser/signin_switches.h [modify] https://crrev.com/30843068b11022756024311347dcbd0490e2ecf6/tools/metrics/histograms/histograms.xml
Comment 1 by blundell@chromium.org
, Dec 29 2017Components: Internals>Services>Identity
Status: Available (was: Assigned)