Zip Archiver: No error message when zipped file became inaccessible while processing |
||||||||||
Issue descriptionChrome Version: 65.0.3307.0 Steps To Reproduce: (1) Turn on --enable-zip-archiver-packer flag. (2) Start to zip a big file (3) Remove the source file being zipped by (2). Expected Result: Zip Archiver notification shows error message. Actual Result: Zip Archiver notification stays frozen, saying "please wait, packing...", until user dismiss it. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) 100% What is the impact to the user, and is there a workaround? If so, what is it? User may dismiss the notification message and continue other operations. Please provide any additional information below. Attach a screen shot or log if possible. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 22 2018
,
Feb 23 2018
,
Feb 28 2018
,
Mar 8 2018
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c5d3313ebb5a367620458189b41c9663cb730c4 commit 6c5d3313ebb5a367620458189b41c9663cb730c4 Author: Tatsuhisa Yamaguchi <yamaguchi@google.com> Date: Mon Apr 02 12:06:28 2018 Create zip file in temporary storage. This will avoid exposing in-progress zip file to the destination folder. It will resolve the issues like: - the zip file is synced to Drive with incomplete state, having multiple revisions - when cancelling zip packing, the file appears in the trash of Drive Bug: 714579 ,785096,785093,785086, 797873 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b32515d5e896d87e1dee499f1eea40dd7a481f0 Reviewed-on: https://chromium-review.googlesource.com/844442 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547428} [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/app.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/background.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/js/compressor.js [modify] https://crrev.com/6c5d3313ebb5a367620458189b41c9663cb730c4/chrome/browser/resources/chromeos/zip_archiver/manifest.json
,
Apr 5 2018
,
May 24 2018
,
May 24 2018
Hi Noel, assigning to you as new owner of Zip, I've done some work on these so we can catch up about them if needed.
,
Aug 16
,
Aug 17
#1 > yamaguchi@ "This will be covered by https://chromium-review.googlesource.com/c/chromium/src/+/844442." So this bug was covered by that change?
,
Aug 17
Yes. Now the archiver shows "Packing failed" error if we do the repro steps. IIRC the change fixed a crash before showing error message for this situation, in addition to its original purpose.
,
Aug 17
Ok thanks. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yamaguchi@chromium.org
, Dec 28 2017